Scoped identity at product alert email #26534

maqlec · 2020-01-24T23:03:11Z

Description (*)

Price/stock alert email was always sended with identity from default store. I fixed that identity sets from store where alert is subscribed

Manual testing scenarios (*)

Subscribe to price/stock alert on other store than default
When notification is sended to customer, as a sender will be contact from scoped store

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Scoped identity at product alert email #28968: Scoped identity at product alert email

m2-assistant · 2020-01-24T23:03:14Z

Hi @maqlec. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

app/code/Magento/ProductAlert/Model/Email.php

Stepa4man

Hi @maqlec
Thanks for your contribution

Please check the test failures.

maqlec · 2020-01-27T10:14:51Z

@Stepa4man failing tests are unrelated to changes. Is there a way to retest only one of them?

maqlec · 2020-05-02T22:08:16Z

Hi @maqlec
Thanks for your contribution

Please check the test failures.

all checks have passed :)

magento-engcom-team · 2020-05-02T23:34:49Z

Hi @Stepa4man, thank you for the review.
ENGCOM-7506 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

magento-engcom-team · 2020-05-02T23:34:51Z

@maqlec thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

engcom-Delta

@maqlec Due to Magento Definition of Done all code must be covered by tests.
Seems like new behavior not covered by existing dev/tests/integration/testsuite/Magento/ProductAlert/Model/EmailTest.php test

Pull Request state was updated. Re-review required.

maqlec · 2020-05-10T12:12:24Z

@engcom-Delta failed tests are not related to changes

Stepa4man · 2020-06-05T20:44:43Z

@magento run all tests

Stepa4man · 2020-06-05T20:49:12Z

Hi @maqlec,

Please add to all changed (created) php files

    declare(strict_types=1);

You can read more here

… alert-sender-scope-fix

engcom-Echo · 2020-06-09T11:39:44Z

@magento run all tests

magento-engcom-team · 2020-06-10T06:37:42Z

Hi @Stepa4man, thank you for the review.
ENGCOM-7506 has been created to process this Pull Request
✳️ @Stepa4man, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Delta · 2020-06-30T14:19:24Z

✔️ QA passed

Manual testing scenario:

Create second store view
Change Sender Email for Second Store View
Configure price/stock alert
Set Display Out of Stock Products=Yes
Create two simple products, one of them is Out of Stock
Create customer
Change view to Second Store view on frontend
For product In Stock, click "Notify me when the price drops" for subscribe to price alert on frontend
For product Out of Stock, click "Notify me when this product is in stock" for subscribe to price alert on frontend
Go to admin panel
Set lower price for product In Stock
Set Stock Status=In Stock for product that was Out of Stock
Change local date to next day
Run cron:run twice
Check customer mail

❌ Before:
Sender Email is from default view

✔️ After:
Sender Email is from view where customer was subscribed for alerts(from Second Store View)

engcom-Delta · 2020-07-02T07:13:15Z

@magento create issue

m2-assistant · 2020-07-11T17:25:07Z

Hi @maqlec, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

maqlec requested review from buskamuza and melnikovi as code owners January 24, 2020 23:03

Stepa4man reviewed Jan 25, 2020

View reviewed changes

app/code/Magento/ProductAlert/Model/Email.php Outdated Show resolved Hide resolved

Stepa4man requested changes Jan 25, 2020

View reviewed changes

ghost assigned Stepa4man Jan 25, 2020

ghost added the Progress: needs update label Jan 25, 2020

maqlec requested a review from Stepa4man January 27, 2020 06:13

set scoped identity at product alert email

da04422

maqlec force-pushed the alert-sender-scope-fix branch from 34efe00 to da04422 Compare May 2, 2020 16:51

Stepa4man previously approved these changes May 2, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels May 2, 2020

magento-engcom-team added Release Line: 2.4 Component: ProductAlert labels May 2, 2020

engcom-Delta self-assigned this May 6, 2020

engcom-Delta requested changes May 6, 2020

View reviewed changes

ghost added Progress: needs update and removed Progress: ready for testing labels May 6, 2020

engcom-Echo self-assigned this May 6, 2020

Maciej Pawłowski added 2 commits May 10, 2020 09:32

integration test for scoped message identity

d88c8d8

merge 2.4-develop

5f3b07d

maqlec requested a review from engcom-Delta May 10, 2020 12:11

static analysis fix

87dde61

Merge branch '2.4-develop' into alert-sender-scope-fix

bba5b16

engcom-Echo added 2 commits June 9, 2020 11:36

Merge branch '2.4-develop' of http://github.com/magento/magento2 into…

f823fc2

… alert-sender-scope-fix

refactoring

a50dcf5

engcom-Echo force-pushed the alert-sender-scope-fix branch from 045659b to a50dcf5 Compare June 9, 2020 11:39

Stepa4man approved these changes Jun 10, 2020

View reviewed changes

ghost added Progress: ready for testing and removed Progress: needs update labels Jun 10, 2020

Stepa4man added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 10, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Jun 30, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Jun 30, 2020

engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 1, 2020

m2-assistant bot mentioned this pull request Jul 2, 2020

[Issue] Scoped identity at product alert email #28968

Closed

4 tasks

engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 2, 2020

ghost added Progress: accept and removed Progress: extended testing labels Jul 2, 2020

slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 8, 2020

slavvka added this to the 2.4.1 milestone Jul 8, 2020

magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020

ENGCOM-7506: Scoped identity at product alert email #26534

39d1e19

magento-engcom-team merged commit 03eff10 into magento:2.4-develop Jul 11, 2020

Scoped identity at product alert email #26534

Scoped identity at product alert email #26534

Uh oh!

Conversation

maqlec commented Jan 24, 2020 • edited by m2-assistant bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description (*)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

Uh oh!

m2-assistant bot commented Jan 24, 2020

Uh oh!

Uh oh!

Stepa4man left a comment

Choose a reason for hiding this comment

Uh oh!

maqlec commented Jan 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

maqlec commented May 2, 2020

Uh oh!

magento-engcom-team commented May 2, 2020

Uh oh!

magento-engcom-team commented May 2, 2020

Uh oh!

engcom-Delta left a comment

Choose a reason for hiding this comment

Uh oh!

maqlec commented May 10, 2020

Uh oh!

Stepa4man commented Jun 5, 2020

Uh oh!

Stepa4man commented Jun 5, 2020

Uh oh!

engcom-Echo commented Jun 9, 2020

Uh oh!

magento-engcom-team commented Jun 10, 2020

Uh oh!

engcom-Delta commented Jun 30, 2020

Uh oh!

engcom-Delta commented Jul 2, 2020

Uh oh!

m2-assistant bot commented Jul 11, 2020

Uh oh!

Uh oh!

maqlec commented Jan 24, 2020 •

edited by m2-assistant bot

Loading

maqlec commented Jan 27, 2020 •

edited

Loading