Skip to content

Customer attribute frontend labels not using the store label values on the frontend #27064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 24, 2020
Merged

Customer attribute frontend labels not using the store label values on the frontend #27064

merged 29 commits into from
Jun 24, 2020

Conversation

nntoan
Copy link
Contributor

@nntoan nntoan commented Feb 28, 2020 •
edited
Loading

Description (*)

From this 3a6b77f, customer attributes on the frontend now able to retrieve frontend labels instead of hard-coding like previous versions. But it should fallback to store labels if there's value set.

Fixed Issues (if relevant)

  1. [2.3.x] Customer attribute frontend labels not using the store label values on the frontend #27063: Store label is not displaying on the frontend

Manual testing scenarios (*)

  1. Set store labels for any customer address attribute
  2. Go to the registration or customer address edit page
  3. The label of attributes not using labels from store labels, it's using default frontend labels.
  4. The label of attributes is using store labels on the checkout page.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 28, 2020

Hi @nntoan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@krishprakash krishprakash self-assigned this Feb 28, 2020
@ghost ghost unassigned krishprakash Feb 28, 2020
@ghost
Copy link

ghost commented Feb 28, 2020

@krishprakash unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@swnsma swnsma self-requested a review February 28, 2020 06:57
@swnsma swnsma self-assigned this Feb 28, 2020
swnsma
swnsma previously requested changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nntoan!
Thank you for your pull request!
It looks nice!

Could you please integration or functional test to cover your changes?

@nntoan nntoan requested a review from swnsma March 3, 2020 02:22
@nntoan nntoan dismissed swnsma’s stale review March 3, 2020 02:28

Changes now covered by integration tests

swnsma
swnsma requested changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nntoan !
Thank you for your update.
It seems that test is failed :(

Maybe we can try directly call \Magento\Customer\Block\DataProviders\AddressAttributeData for a frontend label and check the output?

@nntoan nntoan requested a review from swnsma March 3, 2020 23:25
@nntoan
Copy link
Contributor Author

nntoan commented Mar 4, 2020

@swnsma

Any idea of how the integration test should be fixed? I have no idea why the attribute unable to save the label actually

swnsma
swnsma previously requested changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nntoan,
Please check my comment.

@engcom-Kilo engcom-Kilo self-assigned this Apr 9, 2020
@VladimirZaets VladimirZaets added Priority: P3 May be fixed according to the position in the backlog. Severity: S1 Affects critical data or functionality and forces users to employ a workaround. labels Apr 9, 2020
@VladimirZaets VladimirZaets added this to the 2.4.1 milestone Apr 9, 2020
@VladimirZaets VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 20, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@engcom-Kilo
Copy link
Contributor

Failed MFTF tests (Functional Tests EE, Functional Tests B2B), failed Static test -
are not related to Changes in this Pull Request.

@engcom-Delta engcom-Delta self-assigned this Jun 22, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 22, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@magento-engcom-team magento-engcom-team mentioned this pull request Jun 24, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2020
@slavvka
ENGCOM-7244: Customer attribute frontend labels not using the store l…
f7fe8c4 
…abel values on the frontend #27064
@magento-engcom-team magento-engcom-team merged commit d90dc8a into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @nntoan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nntoan nntoan deleted the fallback-to-storelabels-customer-attributes branch July 14, 2020 09:59
@nntoan
Copy link
Contributor Author

nntoan commented Jul 14, 2020

@magento give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @nntoan. Thank you for your request. I'm working on Magento 2.3-develop instance for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

Assignees

@swnsma swnsma

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Customer Partner: Balance Internet partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
9 participants
@nntoan @magento-engcom-team @engcom-Alfa @engcom-Kilo @swnsma @VladimirZaets @krishprakash @engcom-Delta @slavvka