Handling exception on individual callback

[alok0590]

Description

This PR changes the behaviour how callbacks are executed after DB changes are committed. The issue was if there is an exception from one call back it results in failing other callbacks as well.

So put the try/catch on individual callback instead of entire foreach block.

Manual testing scenarios (*)

1. Have multiple callbacks having one with fatal error.
2. The subsequenct callbackss after one with fatal error won't get executed.

Resolved issues:

1. resolves [Issue] Handling exception on individual callback #28167: Handling exception on individual callback

[m2-assistant]

Hi @alok0590. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @alok0590,
Your changes looks good.
Could you sign Adobe CLA, fix static tests and cover your changes with some tests?

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7136 has been created to process this Pull Request

[magento-engcom-team]

@alok0590 thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Charlie]

✔️ QA Passed
For example, we have 4 callbacks and the first callback has a fatal error.
Before: The critical exception was logged and the next callbacks don't execute.
After: The critical exception was logged and next callbacks execute.

[alok0590]

@slavvka @ihor-sviziev Anything I need to do to get this PR merged ?

[ihor-sviziev]

@alok0590 for now no actions required from your side.

[slavvka]

@alok0590 please resolve the conflicts and re-run tests after upgrade to PHP 7.4

[slavvka]

@alok0590 please resolve the conflicts and re-run tests after upgrade to PHP 7.4

Pull Request state was updated. Re-review required.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7136 has been created to process this Pull Request

[engcom-Charlie]

✔️ QA Passed
For example, we have 4 callbacks and the first callback has a fatal error.
Before: The critical exception was logged and the next callbacks don't execute.
After: The critical exception was logged and next callbacks execute.

[engcom-Charlie]

Failed functional test not related to changes from this PR.

[m2-assistant]

Hi @alok0590, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.