Skip to content

resolved consistency error for merged indexer xml files #27212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 20, 2021
Merged

resolved consistency error for merged indexer xml files #27212

merged 5 commits into from
Aug 20, 2021

Conversation

philippsander
Copy link
Member

@philippsander philippsander commented Mar 9, 2020 •
edited by m2-assistant bot
Loading

The allowed values in classType should be equal in unmerged and merged indexer.xml files

Allowing only letters and backspaces is wrong, since PHP-namespaces can also contain numbers.

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] resolved consistency error for merged indexer xml files #29609: resolved consistency error for merged indexer xml files

@m2-assistant
Copy link

m2-assistant bot commented Mar 9, 2020

Hi @philippsander. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz suggested changes Mar 9, 2020
View reviewed changes
@ghost ghost assigned lbajsarowicz Mar 9, 2020
@philippsander
Copy link
Member Author

@lbajsarowicz If you change it here you should also change the unmerged files

@philippsander
Copy link
Member Author

@lbajsarowicz
I honestly don't see what update is needed here.

The pipeline will never be green since it's a global magento2 issue on ALL pull-requests

@lbajsarowicz
Copy link
Contributor

In my opinion, the regex should be: https://regex101.com/r/bu1w2N/2

@philippsander
Copy link
Member Author

@lbajsarowicz I agree, but with my merge request I was just trying to fix consitency error.

changing the regex would be too drastic

@lbajsarowicz
Copy link
Contributor

lbajsarowicz commented Mar 29, 2020 •
edited
Loading

Actually I sat one longer moment to find out what's the right approach to this regex and we can even extend it:
https://regex101.com/r/bu1w2N/4

@sidolov sidolov added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 17, 2020
@sidolov
Copy link
Contributor

sidolov commented Aug 17, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 17, 2020
Closed
4 tasks
@ghost ghost assigned sidolov Aug 19, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-8038 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@philippsander
Copy link
Member Author

I don't get how I can push this forward. The checks won't execute.

philippsander
philippsander commented Aug 31, 2020
View reviewed changes
Copy link
Member Author

@philippsander philippsander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@ghost ghost assigned philippsander Aug 31, 2020
lbajsarowicz
lbajsarowicz approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Green from my side, although the change is not enough in my opinion.

@engcom-Golf engcom-Golf self-assigned this Sep 29, 2020
@sidolov sidolov added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Sep 29, 2020
@engcom-Golf
Copy link
Contributor

@magento run all tests

@engcom-Golf
Copy link
Contributor

@magento run all tests

@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Sep 30, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-8038 has been created to process this Pull Request

@engcom-Foxtrot engcom-Foxtrot self-assigned this Nov 19, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 20, 2021
@gabrieldagama
ENGCOM-8038: resolved consistency error for merged indexer xml files #…
976fa0f 
…27212
@magento-engcom-team magento-engcom-team merged commit f243874 into magento:2.4-develop Aug 20, 2021
@m2-assistant
Copy link

m2-assistant bot commented Aug 20, 2021

Hi @philippsander, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@philippsander philippsander

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Foxtrot engcom-Foxtrot

@engcom-Golf engcom-Golf

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Indexer Partner: Netz98 partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] resolved consistency error for merged indexer xml files
7 participants
@philippsander @lbajsarowicz @sidolov @magento-engcom-team @engcom-Alfa @engcom-Golf @engcom-Foxtrot