Adjust mechanism that moves all scripts to the end of the page

[krzksz]

Description (*)

This PR introduces a similar change to #27211, we had this feature implemented in our custom extension and we eventually had to increase both ipcre.backtrack_limit and pcre.recursion_limit to something around 1000000 in order for the regular expressions to work for large pages.

Fixed Issues (if relevant)

1. Possibly https://community.magento.com/t5/Magento-2-x-Technical-Issues/Magento-2-3-3-Move-JS-code-to-the-bottom-of-the-page-Error/td-p/348577
2. JsFooterPlugin sets Http Response content empty if PCRE limit reached #26026 - JsFooterPlugin sets Http Response content empty if PCRE limit reached

Manual testing scenarios (*)

1. Change Move JS code to the bottom of the page to Yes under Stores->Configuration->Advanced->Developer.
2. Refresh the caches and open the shopfront.
3. Verify that all script tags are located in the same order right before the end of body tag.

Questions or comments

I am unable to find any tests for this feature and I'm not experienced enough with PHP to write one from scratch so it would be great if someone contributed some tests here. Thanks!

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[ihor-sviziev]

Hi @krzksz,
Please review unit test failure. Other tests failures looks not related to changes from this PR

[krzksz]

Hey @ihor-sviziev, checking it now... I wonder why I was not able to find them before 🤔

[ihor-sviziev]

@magento run Functional Tests B2B

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7154 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

[engcom-Echo]

@magento run all tests

[engcom-Echo]

Need to approve the failures of MCHI tests

[ihor-sviziev]

@engcom-Echo Magento Health Index seems like false positive. Are you sure we need approval for that?

[slavvka]

MCHI failure is false positive, no need to approve

[magento-engcom-team]

Hi @slavvka, thank you for the review.
ENGCOM-7154 has been created to process this Pull Request

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @krzksz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.