-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Speedup bin/magento #27377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speedup bin/magento #27377
Conversation
Hi @kandy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@kandy really good improvement! Thank you! |
Hi @ihor-sviziev, thank you for the review. |
Database compare has no errors, seems like the issue with status reporting and static test failure - known issue, not related to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @kandy. Could you resolve merge conflicts? Thanks!
Pull Request state was updated. Re-review required.
Hi @kandy. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kandy,
Seems like tests still failing, please update your PR to fix them.
@kandy I am closing this PR now due to inactivity. |
Hi @kandy, thank you for your contribution! |
This PR was picked up and merged by internal team, we are waiting for next sync to change status of this to "merged" |
Hi @kandy, thank you for your contribution! |
@ihor-sviziev @vzabaznov Thank you very much for help me deliver it |
Speedup bin/magento by using lazy load + doesn't use unneeded dependencies
Manual testing scenarios (*)
bin/magento
before/after changeContribution checklist (*)