Skip to content

Speedup bin/magento #27377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 28, 2020
Merged

Speedup bin/magento #27377

merged 6 commits into from
Jul 28, 2020

Conversation

kandy
Copy link
Contributor

@kandy kandy commented Mar 20, 2020

Speedup bin/magento by using lazy load + doesn't use unneeded dependencies

Manual testing scenarios (*)

  1. run time bin/magento before/after change
  2. time after should be better

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Mar 20, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ihor-sviziev
Copy link
Contributor

@kandy really good improvement! Thank you!

@ghost ghost assigned kandy Mar 20, 2020
ihor-sviziev
ihor-sviziev previously approved these changes Mar 21, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7167 has been created to process this Pull Request

@ihor-sviziev
Copy link
Contributor

Database compare has no errors, seems like the issue with status reporting and static test failure - known issue, not related to this PR

Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @kandy. Could you resolve merge conflicts? Thanks!

@ghost ghost dismissed ihor-sviziev’s stale review March 25, 2020 12:02

Pull Request state was updated. Re-review required.

@m2-assistant
Copy link

m2-assistant bot commented May 25, 2020

Hi @kandy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@kandy
Copy link
Contributor Author

kandy commented May 25, 2020

@magento run all tests

Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kandy,
Seems like tests still failing, please update your PR to fix them.

@ihor-sviziev
Copy link
Contributor

@kandy I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@m2-assistant
Copy link

m2-assistant bot commented Jun 10, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@vzabaznov vzabaznov reopened this Jul 28, 2020
@ghost ghost unassigned ihor-sviziev Jul 28, 2020
@vzabaznov vzabaznov self-requested a review July 28, 2020 03:00
@vzabaznov
Copy link
Contributor

This PR was picked up and merged by internal team, we are waiting for next sync to change status of this to "merged"

@m2-assistant
Copy link

m2-assistant bot commented Jul 28, 2020

Hi @kandy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kandy
Copy link
Contributor Author

kandy commented Jul 28, 2020

@ihor-sviziev @vzabaznov Thank you very much for help me deliver it

@kandy kandy deleted the sortedModules branch July 28, 2020 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants