Convert MSRP currency of configurable product options

[ashokadewit]

Description

The MSRP of configurable products is updated in Javascript when an option is chosen. Javascript uses an object with prices of the options. The prices in this object are converted to the chosen currency. MSRP prices however were not converted, leading to the price being displayed in a wrong currency.

Manual testing scenarios

1. Enable MAP (Configuration > Sales > Sales > Minimum Advertised Price > Enable MAP).
2. Enable multiple currencies (Configuration > General > Currency Setup > Allowed Currencies)
3. Create a configurable product with options that have an MSRP
4. Go to the frontend and choose a currency that is not the base currency
5. View the product on the frontend a choose an option.

Expected result: The MSRP is converted to the chosen currency
Actual result: The MSRP is not converted but it is labeled as the chosen currency

Note that the MSRP is configured in euro but displayed in dollars with the euro amount.

After applying the change the MSRP is converted:

Rates in table directory_currency_rate:

Resolved issues:

1. resolves [Issue] Convert MSRP currency of configurable product options #29603: Convert MSRP currency of configurable product options

[m2-assistant]

Hi @ashokadewit. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[sidolov]

@magento create issue

[sidolov]

@ashokadewit could you please cover changes with the automated tests?

[engcom-Echo]

I will take care of test coverage.

[engcom-Echo]

@magento run all tests

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8174 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[magento-engcom-team]

@ashokadewit thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Enable MAP (Configuration > Sales > Sales > Minimum Advertised Price > Enable MAP).
2. Enable multiple currencies (Configuration > General > Currency Setup > Allowed Currencies)
3. Create a configurable product with options that have an MSRP
4. Go to the frontend and choose a currency that is not the base currency
5. View the product on the frontend a choose an option.

Before: ✖️ The MSRP is not converted but it is labeled as the chosen currency

After: ✔️ The MSRP is converted to the chosen currency

[engcom-Echo]

@magento run all tests

[m2-assistant]

Hi @ashokadewit, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.