Add missing order_data array to EmailSender classes

[kassner]

Description

Magento 2.3.4 now recommends using scalar variables instead of objects within the email templates. Unfortunately, not all classes were migrated. For example, \Magento\Sales\Model\order\Email\Sender\ShipmentSender was given the new array, despite now it being deprecated, but its replacement, \Magento\Sales\Model\Order\Shipment\Sender\EmailSender did not.

This change was introduced in commits like fd721b1#diff-7b993c70d2652919564eeaf30afe7326. Several more do change the email templates to use order_data instead.

Manual testing scenarios

1. Create a shipment email template using {{order_data.is_not_virtual}} (as opposed to {{order.is_not_virtual}});
2. Send it programatically using \Magento\Sales\Model\Order\Shipment\Sender\EmailSender;

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

Resolved issues:

1. resolves [Issue] Add missing order_data array to EmailSender classes #29604: Add missing order_data array to EmailSender classes

[m2-assistant]

Hi @kassner. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[edenduong]

Hi @kassner: Could you please sign Adobe CLA? And arcording to Magento DOD, please cover your changes by Unit Test. Thank you very much!

[sidolov]

@magento create issue

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-8087 has been created to process this Pull Request

[magento-engcom-team]

Hi @edenduong, thank you for the review.
ENGCOM-8087 has been created to process this Pull Request

[engcom-Delta]

@magento run all tests

[engcom-Delta]

✔️ QA passed
Manual testing scenario:

• Create email template for invoice with additional node in template
  
• Set template for Invoice Email Template and Invoice Email Template for Guest
• Order simple product as guest
• Create invoice for order
• Send invoice email programatically using Magento\Sales\Model\Order\Invoice\Sender\EmailSender

Result:
❌ Before:
No customer name(depends on order_data.customer_name) and shipping address(depends on order_data.is_not_virtual) in email for simple product

✔️ After:
Customer name, custom node and shipping information is displayed in invoice email for simple product

[engcom-Delta]

Note: Functional Tests B2B and Functional Tests EE are failed

[engcom-Delta]

Note: Automation tests are passed

[m2-assistant]

Hi @kassner, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.