#23440 fix Refund for bundle product without receiving product back e…

[KiuNguyen]

Description (*)

Fix Refund for bundle product without receiving the product back getting error

Fixed Issues (if relevant)

1. Fixes Refund for bundle product without receiving product back #23440: Refund for bundle product without receiving product back

Manual testing scenarios (*)

1. Create a bundle product with at least 2 products
2. Create order with bundle product
3. Invoice Order
4. Shop Order
5. Create Credit Memo without taking the product back in stock and only refund amount:

• Change all qty to 0
• Add adjustment refund: 10$
• Click on button update qty

6. After click on update qty, bundle item not render and total refund amount is 25$
   

7. Create credit memo

Expected result (*)
Credit Memo for amount 25$ created

Actual result (*)

Error: "The most money available to refund is xx.xx.

Addition info:

After check issue, I saw this issue happen because the bundle item does not render in the form when all child product qty set to 0

Check function "canRefundItem" in Magento/Sales/Model/Order/CreditmemoFactory.php:145 When we create a refund for bundle product with all item qty = 0

if ($item->getHasChildren()) { foreach ($item->getChildrenItems() as $child) { if (empty($qtys)) { if ($this->canRefundNoDummyItem($child, $invoiceQtysRefundLimits)) { return true; } } else { if (isset($qtys[$child->getId()]) && $qtys[$child->getId()] > 0) { return true; } } } return false; }

The return value will return false and exclude bundle parent item in return result

=> bundle parent item does not render in Magento/Sales/view/adminhtml/templates/order/creditmemo/create/items.phtml
So the qty value for each item not exist

If the bundle item does not render in credit memo page and we create a credit memo, so when the function "createByOrder" to be call, the problem happen:
Magento/Sales/Model/Order/CreditmemoFactory.php:69

$qtyList = isset($data['qtys']) ? $data['qtys'] : [];

$qtyList now is an empty array, but in this case, it should have data contain item_id with qty = 0

So this function will get all available refund qty for each item => the root of issue:

• If credit memo doesn't have adjustment amount, it will create credit memo for all item of bundle product (even we already updated all item qty to 0 - STEP 5 )

• If credit memo have adjustment amount, the error message will show: "The most money available to refund is xxxx"

I have pushed the commit to fix this issue
After apply update code, when we update qty for all bundle item to 0, the bundle item will show correctly:

Result after create credit memo:

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @KiuNguyen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[KiuNguyen]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @KiuNguyen. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @KiuNguyen, here is your Magento instance.
Admin access: https://i-27455-2-4-develop.instances.magento-community.engineering/admin_ccb8
Login: 3a5ccf76 Password: d92ad8214142
Instance will be terminated in up to 3 hours.

[KiuNguyen]

@magento give me test instance

[magento-engcom-team]

Hi @KiuNguyen. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @KiuNguyen, here is your new Magento instance.
Admin access: https://pr-27455.instances.magento-community.engineering/admin_75f2
Login: 16c77c8c Password: 20f715c3e072
Instance will be terminated in up to 3 hours.

[nuzil]

@magento give me test instance

[magento-engcom-team]

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

[nuzil]

@magento give me test instance

[magento-engcom-team]

Hi @nuzil. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @nuzil, here is your new Magento instance.
Admin access: https://pr-27455.instances.magento-community.engineering/admin_5563
Login: 08f7c973 Password: 3e0a69104ac8
Instance will be terminated in up to 3 hours.

[nuzil]

Any particular reason why you do not want to make === compare?

[KiuNguyen]

Hi @nuzil

Any particular reason why you do not want to make === compare?

When I debug, I saw $qtys will return array value like this:

array (size=3)
48 => string '0' (length=1)
49 => string '0' (length=1)
50 => string '0' (length=1)

So now I already update code to use === compare

if (empty($qtys) || (count(array_unique($qtys)) === 1 && (int)end($qtys) === 0)) {

Please check this,
Thanks

[magento-engcom-team]

Hi @nuzil, thank you for the review.
ENGCOM-7460 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
Result:

[m2-assistant]

Hi @KiuNguyen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[vinhan2020]

@magento give me 2.4-develop instance