Skip to content

Fix widget recent view product not fit in mobile view #27572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 15, 2020
Merged

Fix widget recent view product not fit in mobile view #27572

merged 7 commits into from
May 15, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Apr 4, 2020 •
edited by sdzhepa
Loading

Description (*)

Fix for widget recent view product fit again in mobile view

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Recently viewed products in Luma theme does not fit on screen #27058: Recently viewed products in Luma theme does not fit on screen

Manual testing scenarios (*)

  1. Magento 2.3.4+ with sampledata
  2. Theme blank or luma
  3. Add a new widget for "Recently viewed products"
  4. Select Layout update "All pages" and container "Sidebar Main"
  5. View some product in frontend
  6. Visit some products in mobile view until the widget appears in mobile view

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 4, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn mrtuvn changed the title Fix Fix widget recent view product not fit in mobile view Apr 4, 2020
@mrtuvn mrtuvn requested a review from ptylek April 4, 2020 11:35
@edenduong edenduong self-assigned this Apr 4, 2020
edenduong
edenduong requested changes Apr 4, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mrtuvn, thank you for your contribution.
Could you please check the fail static test?

image

@edenduong edenduong added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog labels Apr 4, 2020
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Apr 4, 2020

Fixed code styles follow less magento standards

@mrtuvn mrtuvn requested a review from edenduong April 4, 2020 13:51
edenduong
edenduong approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@edenduong edenduong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7264 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Apr 6, 2020
engcom-Alfa
engcom-Alfa requested changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edenduong
Could you review the latest changes?
Thanks!

@engcom-Alfa engcom-Alfa requested a review from edenduong April 6, 2020 07:18
@magento-engcom-team
Copy link
Contributor

Hi @edenduong, thank you for the review.
ENGCOM-7264 has been created to process this Pull Request

@ghost ghost assigned ptylek Apr 6, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7264 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
luma
widget4

blank
widget3

After:
luma
widget1

blank
widget2

@engcom-Echo engcom-Echo self-assigned this Apr 8, 2020
@VladimirZaets VladimirZaets added this to the 2.4.1 milestone Apr 8, 2020
@VladimirZaets VladimirZaets added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 8, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 12, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request May 15, 2020
Closed
slavvka added a commit that referenced this pull request May 15, 2020
@slavvka
ENGCOM-7264: Fix widget recent view product not fit in mobile view #2…
e2dd73c 
…7572
@slavvka slavvka merged commit 88dc910 into magento:2.4-develop May 15, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 15, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the 27058-fix-recent-view-product-fit-mobile branch June 7, 2020 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Alfa engcom-Alfa engcom-Alfa requested changes

@edenduong edenduong edenduong approved these changes

@ptylek ptylek ptylek approved these changes

Assignees

@edenduong edenduong

@ptylek ptylek

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Event: Global-Contribution-Day Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Recently viewed products in Luma theme does not fit on screen
9 participants
@mrtuvn @magento-engcom-team @engcom-Alfa @edenduong @ptylek @sdzhepa @VladimirZaets @slavvka @engcom-Echo