-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[PERF Improvements]Load polyfills for browsers that don't support certain features #27618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PERF Improvements]Load polyfills for browsers that don't support certain features #27618
Conversation
Hi @krzksz. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
memo: We do have a recording of this demo. |
@krzksz looks like it will be not easy to cover these changes with automatic tests. Do you think it's possible to cover your changes with some tests? |
As we discussed in Slack - it's too hard to cover these changes with automated tests, so I put label "not required" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @krzksz,
Your changes looks good to me.
Could you fix static tests?
Hi @ihor-sviziev, thank you for the review. |
Hi @engcom-Alfa. Thank you for your request. I'm working on Magento instance for you |
Hi @engcom-Alfa, here is your new Magento instance. |
✔️ QA Passed UI components are still functional and polyfills for Map, WeakMap, FormData, and MutationObserver aren't loaded for new browsers. |
@magento create issue |
@magento run all tests |
…t support certain features #27618
Hi @krzksz, thank you for your contribution! |
Description (*)
This PR is a part of my effort to improve Magento 2 frontend performance.
Here I'm using RequireJS configuration and the whole
deps
mechanism to conditionally load browser features polyfils only when needed. Changes in this PR include:Manual testing scenarios (*)
Contribution checklist (*)
Resolved issues: