Skip to content

MC-33148: A link to resend a confirmation email is not clickable #27662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 1, 2020
Merged

MC-33148: A link to resend a confirmation email is not clickable #27662

merged 13 commits into from
May 1, 2020

Conversation

VladimirZaets
Copy link
Contributor

MC-33203: Corrupted compare products page when switch store view
MC-33148: A link to resend a confirmation email is not clickable

Fix for Public PRs:
#25585
#25782

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@VladimirZaets
MC-33148: A link to resend a confirmation email is not clickable
cbcf369 
MC-33203: Corrupted compare products page when switch store view
@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2020

Hi @VladimirZaets. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this Apr 9, 2020
@VladimirZaets VladimirZaets added this to the 2.4.0 milestone Apr 9, 2020
@VladimirZaets VladimirZaets added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Apr 9, 2020
@dmytro-ch dmytro-ch removed their assignment Apr 10, 2020
ihor-sviziev
ihor-sviziev requested changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @VladimirZaets,
Could you add some meaningful description for this PR and fix static test failures?

@ghost ghost assigned ihor-sviziev Apr 13, 2020
@ihor-sviziev
Copy link
Contributor

@VladimirZaets I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@m2-assistant
Copy link

m2-assistant bot commented Apr 28, 2020

Hi @VladimirZaets, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@VladimirZaets VladimirZaets reopened this Apr 29, 2020
@ghost ghost unassigned ihor-sviziev Apr 29, 2020
@VladimirZaets
Copy link
Contributor Author

@ihor-sviziev sorry for the delay:) fixed:)

@ghost ghost assigned slavvka Apr 29, 2020
@ghost ghost dismissed slavvka’s stale review April 29, 2020 23:29

Pull Request state was updated. Re-review required.

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7500 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7500 has been created to process this Pull Request

slavvka added a commit that referenced this pull request May 1, 2020
@slavvka
ENGCOM-7500: MC-33148: A link to resend a confirmation email is not c…
94f5e88 
…lickable #27662
@slavvka slavvka merged commit e85ef38 into magento:2.4-develop May 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2020

Hi @VladimirZaets, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@pointia pointia mentioned this pull request May 18, 2020
Closed
@mrtuvn mrtuvn mentioned this pull request Jul 17, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev requested changes

@slavvka slavvka slavvka approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@VladimirZaets VladimirZaets

@slavvka slavvka

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: Customer Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: accept Release Line: 2.4 Severity: S1 Affects critical data or functionality and forces users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@VladimirZaets @ihor-sviziev @magento-engcom-team @slavvka @dmytro-ch