Skip to content

[MFTF] remove redundunt ActionGroup #27670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

[MFTF] remove redundunt ActionGroup #27670

merged 2 commits into from
May 21, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Apr 9, 2020

Description (*)

This PR removes redundant ActionGroup
app/code/Magento/SalesRule/Test/Mftf/ActionGroup/StorefrontClickOnMiniCartActionGroup.xml
because we already have such ActionGroup in
app/code/Magento/Checkout/Test/Mftf/ActionGroup/StorefrontClickOnMiniCartActionGroup.xml

@m2-assistant
Copy link

m2-assistant bot commented Apr 9, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: SalesRule Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Apr 9, 2020
@rogyar rogyar self-assigned this Apr 9, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Apr 9, 2020
@rogyar
Copy link
Contributor

rogyar commented Apr 9, 2020

Hi @Usik2203. Nice catch, thank you!

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7503 has been created to process this Pull Request

@engcom-Echo engcom-Echo self-assigned this May 4, 2020
@engcom-Alfa engcom-Alfa self-assigned this May 5, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@slavvka slavvka added this to the 2.4.1 milestone May 5, 2020
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7503: [MFTF] remove redundunt ActionGroup #27670
8e3b4ca
@slavvka slavvka merged commit 18b12cc into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: SalesRule Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Alfa @slavvka @engcom-Echo