Skip to content

fixed condition when can show password input. Fixed logic for pulling… #27691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2020
Merged

fixed condition when can show password input. Fixed logic for pulling… #27691

merged 4 commits into from
Aug 26, 2020

Conversation

ProkopovVitaliy
Copy link
Contributor

@ProkopovVitaliy ProkopovVitaliy commented Apr 10, 2020 •
edited by ihor-sviziev
Loading

… email value from persistent storage

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Guest visitor e-mail in checkout kicks off password field visibility #26903 :
    Guest visitor e-mail in checkout kicks off password field visibility

Manual testing scenarios (*)

  1. add items to cart and reach checkout , use a unregistered e-mail in e-mail field and fill address data
  2. go back to cart page (or to any other page as long outside from checkout page)
  3. then go back to checkout page and see that it presents password fields for authenticating for e-mail that is not registered

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 10, 2020

Hi @ProkopovVitaliy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@eduard13 eduard13 self-assigned this Apr 10, 2020
@eduard13
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @eduard13. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, here is your new Magento instance.
Admin access: https://pr-27691.instances.magento-community.engineering/admin_6399
Login: 2a4ed3bc Password: de96e26a9cdc
Instance will be terminated in up to 3 hours.

eduard13
eduard13 requested changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ProkopovVitaliy, could you please cover this fix by an automated test? I'd recommend a simple MFTF test.
Thank you.

@eduard13 eduard13 added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Award: bug fix labels Apr 11, 2020
@ProkopovVitaliy
Copy link
Contributor Author

@eduard13 added MFTF test )

eduard13
eduard13 requested changes Apr 11, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ProkopovVitaliy, thank you for the test coverage, could you please review the minor comments below?

@eduard13 eduard13 added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Apr 11, 2020
eduard13
eduard13 previously approved these changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for collaboration. 👍

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-7312 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@ProkopovVitaliy thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this Apr 13, 2020
@ghost ghost dismissed eduard13’s stale review April 14, 2020 18:50

Pull Request state was updated. Re-review required.

@ProkopovVitaliy ProkopovVitaliy mentioned this pull request Jun 22, 2020
Closed
@mrtuvn mrtuvn mentioned this pull request Jun 23, 2020
Merged
4 tasks
@ihor-sviziev
Copy link
Contributor

@VladimirZaets could you explain why this PR was moved to on hold?

@ghost ghost added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jul 26, 2020
@hostep hostep mentioned this pull request Aug 3, 2020
Closed
5 tasks
@eduard13
Copy link
Contributor

eduard13 commented Aug 3, 2020

Hi @VladimirZaets could you please provides any updates on this PR?
Thank you.

@ghost ghost added the Progress: on hold label Aug 14, 2020
@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Progress: extended testing and removed Progress: on hold labels Aug 14, 2020
@ghost ghost assigned sdzhepa Aug 14, 2020
@sdzhepa
Copy link
Contributor

sdzhepa commented Aug 14, 2020

@ihor-sviziev @eduard13

Sorry for the long delay and silence.
We had several meetings about the initial issue and this PR with PMs developers and UXs.
Long story short, was discussed multiple variants of expected results and changes to the checkout flow(can we accept issue/pr or need to reject or update expected result etc).
As result was created an internal ticket for future improvement.
So, now I do not see any blocker for delivery this PR

@engcom-Foxtrot engcom-Foxtrot self-assigned this Aug 25, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 26, 2020
@gabrieldagama
ENGCOM-7312: fixed condition when can show password input. Fixed logi…
633337a 
…c for pulling… #27691
@magento-engcom-team magento-engcom-team merged commit 0dc8b99 into magento:2.4-develop Aug 26, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 26, 2020

Hi @ProkopovVitaliy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdzhepa sdzhepa sdzhepa approved these changes

@eduard13 eduard13 eduard13 left review comments

Assignees

@sdzhepa sdzhepa

@eduard13 eduard13

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

@engcom-Foxtrot engcom-Foxtrot

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: Checkout Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guest visitor e-mail in checkout kicks off password field visibility
8 participants
@ProkopovVitaliy @eduard13 @magento-engcom-team @engcom-Alfa @ihor-sviziev @sdzhepa @engcom-Echo @engcom-Foxtrot