Skip to content

[MFTF] Fixed file name violations #27839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 5, 2020
Merged

[MFTF] Fixed file name violations #27839

merged 4 commits into from
Jun 5, 2020

Conversation

elevinskii
Copy link
Member

@elevinskii elevinskii commented Apr 13, 2020 •
edited by ghost
Loading

Description

Small file name fixes, based on MFTF conventions.

https://devdocs.magento.com/mftf/docs/best-practices.html#file-names

Resolved issues:

  1. resolves [Issue] [MFTF] Fixed file name violations #28305: [MFTF] Fixed file name violations

@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2020

Hi @elevinskii. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

lbajsarowicz
lbajsarowicz previously approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you!

@ghost ghost assigned lbajsarowicz Apr 13, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7343 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Apr 15, 2020
engcom-Alfa
engcom-Alfa requested changes Apr 15, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @elevinskii. Could you resolve merge conflicts?

@ghost ghost dismissed lbajsarowicz’s stale review April 15, 2020 11:31

Pull Request state was updated. Re-review required.

@elevinskii
Copy link
Member Author

Hi, @elevinskii. Could you resolve merge conflicts?

Sure, the branch is updated, thanks!

@elevinskii elevinskii requested a review from engcom-Alfa April 15, 2020 15:27
VladimirZaets
VladimirZaets previously approved these changes May 1, 2020
View reviewed changes
@ghost ghost assigned VladimirZaets May 1, 2020
@ghost ghost added the Progress: review label May 13, 2020
@elevinskii
Copy link
Member Author

@magento run Functional Tests CE, Functional Tests EE, Functional Tests B2B

@slavvka
Copy link
Member

slavvka commented May 18, 2020

@magento run all tests

@slavvka
Copy link
Member

slavvka commented May 20, 2020

@magento create issue

@ghost ghost mentioned this pull request May 20, 2020
Closed
@magento-engcom-team
Copy link
Contributor

Hi @slavvka, thank you for the review.
ENGCOM-7343 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

engcom-Alfa commented May 21, 2020 •
edited
Loading

QA not applicable

@engcom-Charlie
Copy link
Contributor

Failed functional test not related to changes from this PR.

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 21, 2020
@sdzhepa sdzhepa removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 1, 2020
@engcom-Charlie
Copy link
Contributor

Failed tests not related to changes from this PR.

@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 2, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020
@slavvka
ENGCOM-7343: [MFTF] Fixed file name violations #27839
1f7774b
@magento-engcom-team magento-engcom-team merged commit c5c07de into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @elevinskii, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slavvka slavvka slavvka approved these changes

@lbajsarowicz lbajsarowicz lbajsarowicz left review comments

@VladimirZaets VladimirZaets VladimirZaets left review comments

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

Assignees

@lbajsarowicz lbajsarowicz

@VladimirZaets VladimirZaets

@slavvka slavvka

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Backend Component: Bundle Component: Catalog Component: Customer Component: Downloadable Component: GroupedProduct Component: Security Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Fixed file name violations
8 participants
@elevinskii @magento-engcom-team @engcom-Alfa @slavvka @engcom-Charlie @lbajsarowicz @VladimirZaets @sdzhepa