Skip to content

Improve Interceptor generator #27902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

Improve Interceptor generator #27902

merged 2 commits into from
Jun 5, 2020

Conversation

lbajsarowicz
Copy link
Contributor

@lbajsarowicz lbajsarowicz commented Apr 20, 2020 •
edited by VladimirZaets
Loading

Description (*)

  1. Removed } else { from Interceptors
  2. Replaced foreach with array_map

Performance difference

Running setup:di:compile before and after my changes compared.
image
Means: No performance degradation.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Improve Interceptor generator #28383: Improve Interceptor generator

@m2-assistant
Copy link

m2-assistant bot commented Apr 20, 2020

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@orlangur orlangur self-assigned this Apr 20, 2020
@lbajsarowicz lbajsarowicz force-pushed the refactor/interceptor-else branch from bc0c2be to 42ad52c Compare April 20, 2020 13:49
@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Apr 22, 2020
dmytro-ch
dmytro-ch reviewed Apr 22, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @lbajsarowicz 👍
I briefly checked the results. It looks good to me.

@ghost ghost assigned dmytro-ch Apr 22, 2020
dmytro-ch
dmytro-ch previously approved these changes Apr 24, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7483 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Apr 27, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked setup:di:compile runs with custom modules as before without errors
Was checked setup:di:compile runs without custom modules as before without errors

@engcom-Echo engcom-Echo self-assigned this Apr 27, 2020
@slavvka slavvka added this to the 2.4.1 milestone Apr 27, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Apr 27, 2020
orlangur
orlangur previously approved these changes May 1, 2020
View reviewed changes
@VladimirZaets VladimirZaets added Progress: accept QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) and removed Progress: extended testing Progress: accept labels May 20, 2020
@VladimirZaets
Copy link
Contributor

@magento create issue

@ghost ghost mentioned this pull request May 27, 2020
Closed
4 tasks
@VladimirZaets
Copy link
Contributor

@magento run all tests

@ghost ghost added the Progress: accept label May 27, 2020
@VladimirZaets VladimirZaets added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels May 27, 2020
@engcom-Alfa engcom-Alfa self-assigned this May 29, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Checked php bin/magento setup:di:compile run with and without custom modules

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020
@slavvka
ENGCOM-7483: Improve Interceptor generator #27902
5550eaf
@magento-engcom-team magento-engcom-team merged commit 4fb7d7c into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

@slavvka slavvka slavvka approved these changes

@dmytro-ch dmytro-ch dmytro-ch left review comments

Assignees

@orlangur orlangur

@slavvka slavvka

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Award: special achievement Component: Interception Partner: Mediotype partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Improve Interceptor generator
9 participants
@lbajsarowicz @magento-engcom-team @engcom-Delta @VladimirZaets @engcom-Alfa @engcom-Echo @orlangur @slavvka @dmytro-ch