Improve performance of InterfaceValidator

[lbajsarowicz]

Description (*)

According to the fact that we have:

• 1455 after plugins
• 819 before plugins
• 246 around plugins

in Magento, I changed the order of conditions in Magento Interface Validator that is executed every single time when plugins are mentioned, to improve the logic performance.

Only by changing the order of conditions, we get in average 15% of performance improvement:

Benchmarking method (pseudocode)

for ($i = 0; $i < 1455000; $i++) {
    getMethodType('afterNothingMatters');
}

for ($i = 0; $i < 819000; $i++) {
    getMethodType('beforeNothingMatters');
}

for ($i = 0; $i < 246000; $i++) {
    getMethodType('aroundNothingMatters');
}

for ($i = 0; $i < 1000000; $i++) {
    getMethodType('actuallyNothingMatters');
}

Additionally, replaced Elvis (?:) operator with null coalescing operator (??) which does not juggle types during comparison.

On line 73 you can see that I moved === null comparison before the other comparison because it's cheaper to compare to null than execute additional class method.

Replaced substr comparison with strpos which during my benchmark improved the performance slightly:

After all my changes, the Class performs about 21% faster

How do you...?

The tool used for performance comparisons is blackfire.io

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

N/A

Questions or comments

Support

Solving this issue is supported by Mediotype

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[Dnd-Mafer]

@lbajsarowicz what if you use if confition with continue instead of switch when comparing $methodType ?

[lbajsarowicz]

@lbajsarowicz what if you use if confition with continue instead of switch when comparing $methodType ?

Replaced in both occurrences. Still keeping the number of occurrences in mind.

[dmytro-ch]

The refactored logic is already covered by corresponding test \Magento\Framework\Interception\Test\Unit\Code\InterfaceValidatorTest.

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-7482 has been created to process this Pull Request

[engcom-Delta]

Notice: QA not applicable

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.