Skip to content

ASI: Fix observers #27948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
May 1, 2020
Merged

ASI: Fix observers #27948

merged 33 commits into from
May 1, 2020

Conversation

VladimirZaets
Copy link
Contributor

@VladimirZaets VladimirZaets commented Apr 23, 2020

Description (*)

Parsing all store views for used images while saving a product/categroy

Related Pull Requests

magento/adobe-stock-integration#1251
https://github.com/magento/partners-magento2ee/pull/236
https://github.com/magento/partners-magento2-infrastructure/pull/1

Fixed Issues (if relevant)

  1. Saving the product or category in a specific store view overwrites used in info for other scopes adobe-stock-integration#1278: Saving the product or category in a specific store view overwrites used in info for other scopes

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @VladimirZaets. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor Author

Regarding dependencies on the EAV module. We use methods of abstract class from the EAV module, according to it dependencies on the EAV module is required.

@naydav
Copy link
Contributor

naydav commented Apr 23, 2020

Regarding dependencies on the EAV module. We use methods of abstract class from the EAV module, according to it dependencies on the EAV module is required.

In this case, we have no choice (only global refactoring). The interfaces from Catalog don't provide the needed level of abstraction.

We have the same situation with CatalogSearch module.

"magento/module-eav": "*",

@lenaorobei
Copy link
Contributor

@sivaschenko
Copy link
Member

@VladimirZaets
Copy link
Contributor Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @sivaschenko, thank you for the review.
ENGCOM-7492 has been created to process this Pull Request

@Nazar65
Copy link
Member

Nazar65 commented Apr 29, 2020

✔️ QA Passed

@VladimirZaets
Copy link
Contributor Author

@magento run all tests

@VladimirZaets
Copy link
Contributor Author

@magento run all tests

3 similar comments
@VladimirZaets
Copy link
Contributor Author

@magento run all tests

@VladimirZaets
Copy link
Contributor Author

@magento run all tests

@VladimirZaets
Copy link
Contributor Author

@magento run all tests

slavvka added a commit that referenced this pull request May 1, 2020
@slavvka slavvka merged commit 636565e into magento:2.4-develop May 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 1, 2020

Hi @VladimirZaets, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants