Skip to content

Feature bulgarian country regions #27957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 21, 2020
Merged

Feature bulgarian country regions #27957

merged 5 commits into from
May 21, 2020

Conversation

nikolalardev
Copy link
Contributor

@nikolalardev nikolalardev commented Apr 23, 2020 •
edited by ghost
Loading

Description (*)

Adding Bulgarian regions to directory_country_region table

Related Pull Requests

Manual testing scenarios (*)

  1. Install Magento
  2. Check table directory_country_region for Bulgarian states.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Feature bulgarian country regions #28215: Feature bulgarian country regions

@m2-assistant
Copy link

m2-assistant bot commented Apr 23, 2020

Hi @nikolalardev. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this Apr 24, 2020
rogyar
rogyar requested changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nikolalardev. Thank you for your collaboration. Please, check my comments below for some minor adjustments.

Also, according to the definition of done all changes should be covered by automated tests. You may refer to the following PR that shows how to create an MFTF test for a similar case.

#25590

Thank you.

app/code/Magento/Directory/Setup/Patch/Data/AddDataForBulgaria.php Outdated
*
* Class AddDataForBulgaria
*/
class AddDataForBulgaria implements DataPatchInterface, PatchVersionInterface
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove the PatchVersionInterface dependency. We may omit it in this particular case and remove the redundant getVersion() as result.

@rogyar rogyar added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Progress: needs update labels Apr 24, 2020
@engcom-Echo engcom-Echo self-assigned this May 5, 2020
@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@engcom-Echo engcom-Echo requested a review from rogyar May 6, 2020 05:53
@engcom-Echo
Copy link
Contributor

Hi @rogyar could you please approve it?

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels May 11, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7536 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@nikolalardev thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Alfa engcom-Alfa self-assigned this May 13, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Go to Admin->Stores->Configuration->General->Store Information

Actual Result:
Screenshot from 2020-05-13 10-31-56

Go to Checkout process->Shipping

Actual Result:
Screenshot from 2020-05-13 10-35-56

@slavvka
Copy link
Member

slavvka commented May 13, 2020

@magento create issue

@ghost ghost mentioned this pull request May 13, 2020
Closed
4 tasks
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 14, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 14, 2020
@sdzhepa sdzhepa added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label May 20, 2020
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7536: Feature bulgarian country regions #27957
61b94c5
@slavvka slavvka merged commit 6b08ff2 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @nikolalardev, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@nikolalardev nikolalardev deleted the feature-bulgarian-country-regions branch June 16, 2020 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Directory Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Feature bulgarian country regions
7 participants
@nikolalardev @engcom-Echo @magento-engcom-team @engcom-Alfa @slavvka @rogyar @sdzhepa