Skip to content

Complex message added for add to cart success message #27977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2020
Merged

Complex message added for add to cart success message #27977

merged 4 commits into from
Aug 8, 2020

Conversation

ajithkumar-maragathavel
Copy link
Contributor

@ajithkumar-maragathavel ajithkumar-maragathavel commented Apr 24, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Usually when we add a product from the product listing page or product description page.
The add to cart success message will come up with the shopping cart link attached to it.

Please refer the below screenshot:
success-message-with-link

But when we add the products from the customer account sidebar (Recently ordered product or Wishlist), The add to cart success message will not come up with the shopping cart link.

Please refer the below screenshot:
success-message-without-link

Please refer to the customer account sidebar screenshot below:
sidebar-add-to-cart

Therefore I have replaced the existing message with the add to cart success complex message with the shopping cart link.

Manual testing scenarios (*)

  1. Added a product from the customer account sidebar to the cart and verified the success message comes up with the shopping cart link.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Complex message added for add to cart success message #29097: Complex message added for add to cart success message

@m2-assistant
Copy link

m2-assistant bot commented Apr 24, 2020

Hi @ajithkumar-maragathavel. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@srsathish92
Copy link
Contributor

Hello @ajithkumar-maragathavel , thank you for the contribution.

Please note, due to Magento Definition of Done the changes must be covered by tests. Could you please cover your fix by the appropriate unit test?

Thank you!

@VladimirZaets
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 13, 2020
Closed
4 tasks
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 13, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests label Jul 29, 2020
ihor-sviziev
ihor-sviziev requested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ajithkumar-maragathavel,
Could you resolve merge conflict & cover your change with some kind of test?

@ghost ghost assigned ihor-sviziev Jul 29, 2020
@engcom-Echo engcom-Echo self-assigned this Jul 29, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jul 31, 2020
@engcom-Echo engcom-Echo force-pushed the complex-error-message branch from 9094c7c to 812d943 Compare August 3, 2020 10:48
@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7949 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Preconditions:

  1. Have at least 1 simple product;
  2. Create a new customer;
  3. One created order;

Manual testing scenario:

  1. Add the product to cart from the customer account sidebar (Recently ordered product)

Before: ✖️ The add to cart success message came up without the shopping cart link attached to it.

2020-08-05_09-39

After: ✔️ The add to cart success message came up with the shopping cart link attached to it.

2020-08-05_09-51

  1. Add the product to cart from the customer account sidebar (Wishlist)

Before: ✖️ The add to cart success message came up without the shopping cart link attached to it.

2020-08-05_09-44

After: ✔️ The add to cart success message came up with the shopping cart link attached to it.

2020-08-05_09-52

Also was tested on the Blank theme and everything works as expected.

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 5, 2020
@engcom-Alfa engcom-Alfa self-assigned this Aug 5, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 6, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@slavvka
ENGCOM-7949: Complex message added for add to cart success message #2…
63e47b8 
…7977
@magento-engcom-team magento-engcom-team merged commit 1f0586d into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @ajithkumar-maragathavel, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Echo engcom-Echo engcom-Echo left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Checkout Component: Wishlist Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Complex message added for add to cart success message
7 participants
@ajithkumar-maragathavel @srsathish92 @VladimirZaets @engcom-Echo @magento-engcom-team @engcom-Alfa @ihor-sviziev