Skip to content

Fix inconsistent visual labels form login in theme blank #28084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 21, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented May 2, 2020

Description (*)

After this patch apply will have
#1 Remove unnecessary styles set width for container control wrap input fields
#2 Make login form visual look consistently like other form in blank theme (previous fix not good for UX)

Related Pull Requests

#27544

Fixed Issues (if relevant)

  1. fixes Missaligned fields on the Customer Login form #28059: Missaligned fields on the Customer Login form

Manual testing scenarios (*)

  1. Magento CE 2.3.5+
  2. Magento Blank Theme is used.
  3. Screen/Browser width >= 768px.
  4. Go to account login page

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 2, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn mrtuvn changed the title Fix inconsistent visual labels form login in blank Fix inconsistent visual labels form login in theme blank May 2, 2020
@ptylek
Copy link
Contributor

ptylek commented May 3, 2020

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @ptylek. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, here is your new Magento instance.
Admin access: https://pr-28084.instances.magento-community.engineering/admin_0017
Login: 276123b3 Password: a9eaee57d73f
Instance will be terminated in up to 3 hours.

@ghost ghost assigned ptylek May 3, 2020
@ptylek ptylek added the Cleanup label May 3, 2020
@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label May 3, 2020
@ptylek
Copy link
Contributor

ptylek commented May 3, 2020

Functional Tests B2B fails not related to PR

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-7507 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 5, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual tesing scenario:

  1. Login to the admin panel;
  2. Navigate to the Content -> Design -> Configuration.
  3. Open the Global Store and set the applied theme to 'Magento Blank'.
  4. Clean the cache(s).
  5. Open the storefront and navigate to the 'Sign In' page (Screen/Browser width >= 768px)

Before: ✖️ Input fields on the form aren't inline with the labels

Screenshot from 2020-05-05 09-49-05

After: ✔️ Input fields on the form inline with the labels

Screenshot from 2020-05-05 09-54-38

The design of all other forms on the default Blank Theme is the same. Like this:
Screenshot from 2020-05-05 10-21-57

@ghost ghost added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label May 6, 2020
@engcom-Charlie
Copy link
Contributor

The failing functional tests are not related to the change in this pr.

@slavvka slavvka added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 7, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 7, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the fix-inline-labels-form-blank-login branch June 7, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missaligned fields on the Customer Login form
6 participants