Skip to content

LoginToStorefrontActionGroup action group is utilize in existing MFTF #28113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 21, 2020
Merged

LoginToStorefrontActionGroup action group is utilize in existing MFTF #28113

merged 2 commits into from
May 21, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented May 5, 2020 •
edited by ghost
Loading

Description (*)

LoginToStorefrontActionGroup is utilized to replace sequence of actions which has used for store front customer login.

Manual testing scenarios (*)

  1. Run the StorefrontPurchaseProductWithCustomOptionsWithLongValuesTitleTest, StorefrontDeleteCustomerAddressTest, StorefrontPersistedCustomerLoginTest, ConfigurableProductChildImageShouldBeShownOnWishListTest, StorefrontDeletePersistedWishlistTest and verified the test runs successfully.

Questions or comments

If any please let me know your feedback's.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] LoginToStorefrontActionGroup action group is utilize in existing MFTF #28165: LoginToStorefrontActionGroup action group is utilize in existing MFTF

@m2-assistant
Copy link

m2-assistant bot commented May 5, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@rogyar rogyar self-assigned this May 6, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label May 6, 2020
rogyar
rogyar requested changes May 6, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @srsathish92. Thank you for your collaboration.

LoginToStorefrontActionGroup is a legacy action group. Also, it has a name that does not meet the naming convention.

Please, use the following action groups StorefrontFillCustomerLoginFormActionGroup + StorefrontClickSignOnCustomerLoginFormActionGroup instead of LoginToStorefrontActionGroup

Thank you!

@srsathish92
Copy link
Contributor Author

@rogyar Thanks for your feedback. As per your suggestions, I have updated action groups. can you please review now?

@srsathish92 srsathish92 requested a review from rogyar May 6, 2020 19:30
@engcom-Echo engcom-Echo self-assigned this May 7, 2020
rogyar
rogyar approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current change

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7529 has been created to process this Pull Request

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

@engcom-Alfa engcom-Alfa self-assigned this May 8, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo
Copy link
Contributor

Failed functional tests not related to the changes in this PR

@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 8, 2020
@slavvka
Copy link
Member

slavvka commented May 8, 2020

@magento create issue

@ghost ghost mentioned this pull request May 8, 2020
Closed
4 tasks
@slavvka slavvka added this to the 2.4.1 milestone May 8, 2020
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7529: LoginToStorefrontActionGroup action group is utilize in …
3a61d11 
…existing MFTF #28113
@slavvka slavvka merged commit 3cfcfa6 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: MFTF test coverage Component: Catalog Component: Customer Component: Wishlist Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] LoginToStorefrontActionGroup action group is utilize in existing MFTF
6 participants
@srsathish92 @magento-engcom-team @engcom-Echo @engcom-Alfa @slavvka @rogyar