Skip to content

Update Issue and PR templates #28168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 21, 2020
Merged

Update Issue and PR templates #28168

merged 3 commits into from
May 21, 2020

Conversation

sdzhepa
Copy link
Contributor

@sdzhepa sdzhepa commented May 8, 2020

Description (*)

This PR contains 2 improvements/updates

1. Updated Issue related templates

Added section that allows a reporter to set initial Severity during issue reporting as it described on DevDoc Who and how can define severity and priority

Issue reporters can provide their own evaluation for severity by selecting a checkbox in the Issue description.

2. Improve Pull Request templates

Added keyword to the section Fixed Issue

Fixes magento/magento2#<issue_number>

This keyword should improve automatically linking PR -> Issue, according to GitHub documentation Linking a pull request to an issue using a keyword

@m2-assistant
Copy link

m2-assistant bot commented May 8, 2020

Hi @sdzhepa. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sdzhepa
Copy link
Contributor Author

sdzhepa commented May 8, 2020

@magento run all tests

Fix based on code review
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved ✔
Test failures are definitely not related to changes in this PR.

@ghost ghost assigned ihor-sviziev May 12, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels May 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7537 has been created to process this Pull Request

@ghost ghost assigned okorshenko May 12, 2020
@okorshenko okorshenko added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label May 12, 2020
@magento-engcom-team
Copy link
Contributor

Hi @okorshenko, thank you for the review.
ENGCOM-7537 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 13, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this May 13, 2020
@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to changes from this PR.

@slavvka slavvka added this to the 2.4.1 milestone May 13, 2020
slavvka added a commit that referenced this pull request May 21, 2020
@slavvka slavvka merged commit 3f73f7a into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @sdzhepa, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants