Skip to content

Added missing translation for modal title & buttons on admin #28174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2020
Merged

Added missing translation for modal title & buttons on admin #28174

merged 1 commit into from
May 21, 2020

Conversation

srsathish92
Copy link
Contributor

@srsathish92 srsathish92 commented May 9, 2020 •
edited by ghost
Loading

Description (*)

Added missing translation for modal title & buttons in modal (Customers -> Add New Address, Edit Product -> Advanced Inventory) on Admin.

Related Pull Requests

NA

Manual testing scenarios (*)

  1. Magento/Customer/i18n/en_US.csv ("Add/Update Address","Test Add/Update Address")
  2. Go to Admin Customers -> Addresses -> Add New Address -> see Modal Title (Add/Update Address)
  3. Magento/CatalogInventory/i18n/en_US.csv ("Advanced Inventory","Test Advanced Inventory")
  4. Go to Admin Catalog -> products -> Edit/Add product -> click "Advanced Inventory" -> see Modal Title (Advanced Inventory) & Modal Button (Done)

Questions or comments

NA

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Added missing translation for modal title & buttons on admin #28201: Added missing translation for modal title & buttons on admin

@m2-assistant
Copy link

m2-assistant bot commented May 9, 2020

Hi @srsathish92. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label May 10, 2020
@ghost ghost assigned dmytro-ch May 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7535 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this May 12, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

Case 1

  1. Magento/Customer/i18n/en_US.csv ("Add/Update Address","Test Add/Update Address")
  2. Go to Admin Customers -> Addresses -> Add New Address -> see Modal Title (Add/Update Address)

Before: ✖️
screenshot_1

After: ✔️
screenshot_5

Case 2

  1. Magento/Catalog/i18n/en_US.csv ("Advanced Inventory","Test Advanced Inventory") and ("Done","Test Done")
  2. Go to Admin Catalog -> products -> Edit/Add product -> click "Advanced Inventory" -> see Modal Title (Advanced Inventory) & Modal Button (Done)

Before: ✖️
screenshot_4

After: ✔️
screenshot_6

@engcom-Charlie engcom-Charlie self-assigned this May 12, 2020
@engcom-Charlie
Copy link
Contributor

Failed functional tests not related to changes from this PR.

@slavvka
Copy link
Member

slavvka commented May 12, 2020

@magento create issue

@ghost ghost mentioned this pull request May 12, 2020
Closed
4 tasks
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels May 12, 2020
@slavvka slavvka added this to the 2.4.1 milestone May 12, 2020
@VladimirZaets VladimirZaets added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label May 19, 2020
@sdzhepa sdzhepa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels May 20, 2020
@ghost ghost assigned sdzhepa May 20, 2020
@magento-engcom-team
Copy link
Contributor

Hi @sdzhepa, thank you for the review.
ENGCOM-7535 has been created to process this Pull Request

slavvka added a commit that referenced this pull request May 21, 2020
@slavvka
ENGCOM-7535: Added missing translation for modal title & buttons on a…
24e6cde 
…dmin #28174
@slavvka slavvka merged commit 83c45b6 into magento:2.4-develop May 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2020

Hi @srsathish92, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdzhepa sdzhepa sdzhepa approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@sdzhepa sdzhepa

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: CatalogInventory Component: Customer Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] Added missing translation for modal title & buttons on admin
8 participants
@srsathish92 @magento-engcom-team @engcom-Alfa @engcom-Charlie @slavvka @sdzhepa @dmytro-ch @VladimirZaets