Skip to content

Multiple arguments in module:status command #28250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 8, 2020
Merged

Multiple arguments in module:status command #28250

merged 7 commits into from
Aug 8, 2020

Conversation

chandru-199
Copy link
Contributor

@chandru-199 chandru-199 commented May 18, 2020 •
edited by m2-assistant bot
Loading

Description (*)

As of now module:status command accepts only one parram. But module:enable and module:disable accepts multiple module names as argument. So, in same way module:status command also can accept multiple module names as argument.

Related Pull Requests

NA

Manual testing scenarios (*)

  1. Run module:status command with multiple module names. ex module:status module1 module2.
  2. We will get cli output in following pattern.
    module1 : Module is enabled
    module2 : Module is disabled

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Multiple arguments in module:status command #29344: Multiple arguments in module:status command

@m2-assistant
Copy link

m2-assistant bot commented May 18, 2020

Hi @chandru-199. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered only manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s). <test-build(s)> is a comma-separated list of build names. Allowed build names are Database Compare, Functional Tests CE, Functional Tests EE, Functional Tests B2B, Integration Tests, Magento Health Index, Sample Data Tests CE, Sample Data Tests EE, Sample Data Tests B2B, Static Tests, Unit Tests, WebAPI Tests.

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@chandru-199
Copy link
Contributor Author

@magento run Static Tests

@ihor-sviziev ihor-sviziev self-assigned this Jul 29, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

ihor-sviziev
ihor-sviziev requested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @chandru-199,
Could you fix static test failures?

@ihor-sviziev ihor-sviziev added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 29, 2020
@ihor-sviziev ihor-sviziev added the Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. label Jul 29, 2020
@engcom-Charlie engcom-Charlie self-assigned this Jul 30, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@chandru-199
Copy link
Contributor Author

@ihor-sviziev : sure.

@chandru-199
Copy link
Contributor Author

chandru-199 commented Jul 30, 2020 •
edited
Loading

Thank you @engcom-Charlie for your static test fix.

ihor-sviziev
ihor-sviziev requested changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have few small issues. Please check them.

Everything else looks good to me

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7925 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 31, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 31, 2020
Closed
4 tasks
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Manual testing scenario:

Run module:status command with multiple module names. ex php bin/magento module:status Magento_Version Magento_Wishlist.

Before: ✖️ Too many arguments....

Screenshot from 2020-07-31 13-26-53

After: ✔️ We got CLI output in the following pattern.
Magento_Version : Module is disabled
Magento_Wishlist : Module is enabled

Screenshot from 2020-07-31 13-24-17

Case 2. With one non-existent module

Run module:status command with multiple module names. ex php bin/magento module:status Magento_Version Magento_Test.

After: ✔️ We got CLI output in the following pattern.

Screenshot from 2020-07-31 13-25-15

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Aug 3, 2020
@ghost ghost added Priority: P3 May be fixed according to the position in the backlog. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. and removed Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Aug 3, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Aug 7, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@slavvka
ENGCOM-7925: Multiple arguments in module:status command #28250
3d1cde5
@magento-engcom-team magento-engcom-team merged commit ffca463 into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @chandru-199, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@chandru-199 chandru-199 mentioned this pull request Aug 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Setup Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Multiple arguments in module:status command
5 participants
@chandru-199 @ihor-sviziev @engcom-Charlie @magento-engcom-team @engcom-Alfa