Fix #26427 - Admin config section not expanded when fields are required.

[Bartlomiejsz]

Description (*)

This is fix for #26427

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Admin config section not expanded when fields are required. #26427: Admin config section not expanded when fields are required.

Manual testing scenarios (*)

Check fixed issue for testing steps and expected result

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[Bartlomiejsz]

@magento run all tests

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-7619 has been created to process this Pull Request

[engcom-Alfa]

Hi @Bartlomiejsz .

During testing, we faced the issue.

Problem: Second config section not expanded when the inside field is required.

Precondition:

Have 3 groups in the system configuration (Test 1 and Test 3 required for ex.)

Manual testing scenario:

1. Leave the values of the 3 groups blank;
2. Click on Save button;

Actual Result: ✖️ Only the first tab expanded with required fields and scrolled to it, but the second tab is not expanded

Note: The second (Test 3) expands only if we fill in the first (Test 1). It would be more convenient if all the tabs were opened at once.

@Bartlomiejsz @dmytro-ch Could you take a look?

Thanks!

Pull Request state was updated. Re-review required.

[Bartlomiejsz]

@magento run all tests

[Bartlomiejsz]

Hi @engcom-Alfa, I modified code so all sections that contains invalid field will be expanded

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7619 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Precondition:

Have 3 groups in the system configuration (Test 1 and Test 3 required for ex.)

Manual testing scenario:

1. Leave the values of the 3 groups blank;
2. Click on Save button;

Before: ✖️ Nothing happens, from customer / UX point of view system hangs and there is no error message

After: ✔️ The system has expanded all tabs with empty required fields

[engcom-Charlie]

@magento run all tests

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.