Skip to content

Update Customer data with REST API #28332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 18, 2020
Merged

Update Customer data with REST API #28332

merged 4 commits into from
Jun 18, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed issue and tests

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Update Customer data with REST API #21237

Manual testing scenarios (*)

See #21237

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 22, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@dmytro-ch dmytro-ch self-assigned this May 22, 2020
@engcom-Charlie engcom-Charlie changed the title Update Customer data with REST API [WIP] Update Customer data with REST API May 22, 2020
Serializator
Serializator reviewed May 22, 2020
View reviewed changes
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title [WIP] Update Customer data with REST API Update Customer data with REST API May 29, 2020
@engcom-Charlie
Copy link
Contributor Author

Hi @dmytro-ch, can You please review this PR?

@ihor-sviziev ihor-sviziev self-assigned this Jun 4, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Jun 4, 2020
ihor-sviziev
ihor-sviziev reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

ihor-sviziev
ihor-sviziev approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔ Approved.

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7618 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7618 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 10, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Precondition

Have one created customer

Manual testing scenario:

Send PUT request /rest/V1/customers/{customer_id} to update the customer

Screenshot from 2020-06-10 10-18-00

Before: ✖️ 400. The customer email is missing

Screenshot from 2020-06-10 10-38-49

After: ✔️ The customer was successfully updated

Screenshot from 2020-06-10 10-18-14

@engcom-Echo engcom-Echo self-assigned this Jun 10, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 10, 2020
@slavvka slavvka added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 11, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 11, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 18, 2020
@slavvka slavvka mentioned this pull request Jun 18, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jun 18, 2020
@slavvka
ENGCOM-7618: Update Customer data with REST API #28332
73558cf
@magento-engcom-team magento-engcom-team merged commit 9b0de12 into magento:2.4-develop Jun 18, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@ihor-sviziev ihor-sviziev mentioned this pull request Sep 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serializator Serializator Serializator left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@dmytro-ch dmytro-ch dmytro-ch approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

Update Customer data with REST API
8 participants
@engcom-Charlie @magento-engcom-team @engcom-Alfa @ihor-sviziev @Serializator @dmytro-ch @slavvka @engcom-Echo