Skip to content

MFTF: Refactoring AdminGenerateUrlRewritesForProductInCategoriesSwitchOffTest #28401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 24, 2020
Merged

MFTF: Refactoring AdminGenerateUrlRewritesForProductInCategoriesSwitchOffTest #28401

merged 3 commits into from
Jun 24, 2020

Conversation

kate-kyzyma
Copy link
Contributor

Description (*)

AdminGenerateUrlRewritesForProductInCategoriesSwitchOffTest is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

N/A

Manual testing scenarios (*)

Run the AdminGenerateUrlRewritesForProductInCategoriesSwitchOffTest in the local environment and verified the test runs successfully.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 28, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 28, 2020
@dmytro-ch dmytro-ch self-assigned this May 28, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 4, 2020
dmytro-ch
dmytro-ch previously approved these changes Jun 4, 2020
View reviewed changes
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7620 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 9, 2020
engcom-Alfa
engcom-Alfa requested changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@engcom-Alfa engcom-Alfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kate-kyzyma . Could you resolve merge conflicts? Thanks!

@ghost ghost dismissed dmytro-ch’s stale review June 9, 2020 07:37

Pull Request state was updated. Re-review required.

@kate-kyzyma
Copy link
Contributor Author

Hi @engcom-Alfa

The merge conflict is resolved.

@engcom-Alfa engcom-Alfa requested a review from dmytro-ch June 9, 2020 12:16
@kate-kyzyma
Copy link
Contributor Author

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7620 has been created to process this Pull Request

@dmytro-ch dmytro-ch requested a review from engcom-Alfa June 19, 2020 05:57
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jun 19, 2020
@slavvka
Copy link
Member

slavvka commented Jun 24, 2020

@magento run all tests

magento-engcom-team pushed a commit that referenced this pull request Jun 24, 2020
@slavvka
ENGCOM-7620: MFTF: Refactoring AdminGenerateUrlRewritesForProductInCa…
4d82a5b 
…tegoriesSwitchOffTest #28401
@magento-engcom-team magento-engcom-team merged commit 6ac5359 into magento:2.4-develop Jun 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 24, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmytro-ch dmytro-ch dmytro-ch approved these changes

@engcom-Alfa engcom-Alfa Awaiting requested review from engcom-Alfa

Assignees

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: UrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kate-kyzyma @dmytro-ch @magento-engcom-team @engcom-Alfa @slavvka @engcom-Charlie