Skip to content

MFTF: Refactoring AdminUrlRewritesForProductInAnchorCategoriesTest #28408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kate-kyzyma
Copy link
Contributor

Description (*)

AdminUrlRewritesForProductInAnchorCategoriesTest is refactored according to the best practices followed by MFTF.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

Run AdminUrlRewritesForProductInAnchorCategoriesTest in the local environment and verified the test runs successfully.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 28, 2020

Hi @kate-kyzyma. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 28, 2020
@dmytro-ch dmytro-ch self-assigned this May 28, 2020
@dmytro-ch
Copy link
Contributor

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, here is your new Magento instance.
Admin access: https://pr-28408.instances.magento-community.engineering/admin_b1b0
Login: b7ae5747 Password: 83fc2154e154
Instance will be terminated in up to 3 hours.

@dmytro-ch
Copy link
Contributor

@magento run all tests

@lbajsarowicz lbajsarowicz changed the title Mfte: Refactoring AdminUrlRewritesForProductInAnchorCategoriesTest MFTF: Refactoring AdminUrlRewritesForProductInAnchorCategoriesTest May 29, 2020
lbajsarowicz
lbajsarowicz previously approved these changes May 29, 2020
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Thank you for your contribution

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7596 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label May 29, 2020
@engcom-Alfa engcom-Alfa self-assigned this May 29, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @kate-kyzyma.
Looks like there is an issue with one of the ancestor test.
Could you please evaluate and apply the appropriate changes if necessary?
AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest.

[NOTE] Merge Error - Step could not be found in either TestXML or DeltaXML.                                          
 !                      Test: 'AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest'        TestStep:                   
 !        'goToCategoryPage'    LinkedStep: 'seeValue4' in Test                                                            
 !        "AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest"                                            
 !        /Users/kate/Sites/magento2/app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminUrlRewritesForProductInAnchorCatego
 !        riesTest/AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest.xml                                 
 !        Test configuration:                                                                                           
 !        {"tests":["AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest"],"suites":null} 

Thank you!

@ghost ghost dismissed lbajsarowicz’s stale review May 29, 2020 14:41

Pull Request state was updated. Re-review required.

…Test which extends AdminUrlRewritesForProductInAnchorCategoriesTest
@kate-kyzyma
Copy link
Contributor Author

Hi @dmytro-ch
I have updated the child test to fix the issue. Please, check.

Thanks.

@engcom-Charlie
Copy link
Contributor

@magento run all tests

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-7596 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 3, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 3, 2020
@magento-engcom-team magento-engcom-team merged commit 09d4afa into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @kate-kyzyma, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@kate-kyzyma kate-kyzyma deleted the Refactoring-AdminUrlRewritesForProductInAnchorCategoriesTest branch June 24, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: UrlRewrite Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants