-
Notifications
You must be signed in to change notification settings - Fork 9.4k
MFTF: Refactoring AdminUrlRewritesForProductInAnchorCategoriesTest #28408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFTF: Refactoring AdminUrlRewritesForProductInAnchorCategoriesTest #28408
Conversation
Hi @kate-kyzyma. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @dmytro-ch. Thank you for your request. I'm working on Magento instance for you |
Hi @dmytro-ch, here is your new Magento instance. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ Thank you for your contribution
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA Passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @kate-kyzyma.
Looks like there is an issue with one of the ancestor test.
Could you please evaluate and apply the appropriate changes if necessary?
AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest
.
[NOTE] Merge Error - Step could not be found in either TestXML or DeltaXML.
! Test: 'AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest' TestStep:
! 'goToCategoryPage' LinkedStep: 'seeValue4' in Test
! "AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest"
! /Users/kate/Sites/magento2/app/code/Magento/UrlRewrite/Test/Mftf/Test/AdminUrlRewritesForProductInAnchorCatego
! riesTest/AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest.xml
! Test configuration:
! {"tests":["AdminUrlRewritesForProductInAnchorCategoriesTestAllStoreViewTest"],"suites":null}
Thank you!
Pull Request state was updated. Re-review required.
…tInAnchorCategoriesTest
…Test which extends AdminUrlRewritesForProductInAnchorCategoriesTest
Hi @dmytro-ch Thanks. |
@magento run all tests |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
Hi @kate-kyzyma, thank you for your contribution! |
Description (*)
AdminUrlRewritesForProductInAnchorCategoriesTest is refactored according to the best practices followed by MFTF.
Related Pull Requests
Fixed Issues (if relevant)
Manual testing scenarios (*)
Run AdminUrlRewritesForProductInAnchorCategoriesTest in the local environment and verified the test runs successfully.
Questions or comments
Contribution checklist (*)