Skip to content

[integration] Refactoring AdvancedPricingImportExport fixture #28450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2020
Merged

[integration] Refactoring AdvancedPricingImportExport fixture #28450

merged 2 commits into from
Jun 5, 2020

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR refactores AdvancedPricingImportExport fixture.

@m2-assistant
Copy link

m2-assistant bot commented May 31, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 31, 2020
@Usik2203
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jun 1, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup labels Jun 1, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jun 1, 2020

@magento run all tests

@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jun 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7603 has been created to process this Pull Request

rogyar
rogyar previously approved these changes Jun 1, 2020
View reviewed changes
@ghost ghost assigned rogyar Jun 1, 2020
@rogyar rogyar dismissed their stale review June 1, 2020 17:44

Wrong pr

@rogyar rogyar removed their assignment Jun 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7603 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jun 2, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Jun 2, 2020
@engcom-Charlie
Copy link
Contributor

Failed tests not related to changes from this PR.

@slavvka slavvka added the Priority: P3 May be fixed according to the position in the backlog. label Jun 2, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 2, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 5, 2020
@slavvka
ENGCOM-7603: [integration] Refactoring AdvancedPricingImportExport fi…
6e5563d 
…xture #28450
@magento-engcom-team magento-engcom-team merged commit b9dc62b into magento:2.4-develop Jun 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 5, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@rogyar rogyar rogyar left review comments

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Cleanup Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
7 participants
@Usik2203 @magento-engcom-team @engcom-Alfa @engcom-Charlie @ihor-sviziev @rogyar @slavvka