-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Remove redundant argument in method useProductItem #28466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant argument in method useProductItem #28466
Conversation
Hi @Usik2203. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
Hi @aleron75, thank you for the review. |
Failing functional tests don't seem related to this PR so I approved. |
✔️ QA Passed Checked general Compare functionality and it still works as previous (expected) |
Hi @Usik2203, thank you for your contribution! |
Description (*)
I see that method
useProductItem(true)
gettrue
as argumentBut actually if i will see in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Catalog/Model/ResourceModel/Product/Compare/Item/Collection.php#L367 I see that method
useProductItem()
does not accept any argument