Cli config show returns Configuration ... doesn't exist if value is 0 or empty string

[engcom-Charlie]

Description (*)

Fixed and covered by test.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes ./bin/magento config:show returns "Configuration for path: '...' doesn't exist" if config value equals to 0 or empty string #23290

Manual testing scenarios (*)

1. Set any config to 0 or '' (empty string)
2. Check value cli bin/magento config:show {{path}}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Charlie]

@magento run all tests

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-7629 has been created to process this Pull Request

[engcom-Alfa]

Hi @engcom-Charlie .

During testing, we faced the issue.

Manual testing scenario:

1. Run in console command: ./bin/magento config:set analytics/subscription/enabled '' for example;
   ✔️ Value was saved
   

2. Run command: ./bin/magento config:show analytics/subscription/enabled

Actual Result: ✖️ Configuration for path doesn't exist..

Note: In core_config_data table config was saved with value "NULL"

@engcom-Charlie Could you take a look?
Thanks!

Pull Request state was updated. Re-review required.

[magento-engcom-team]

Hi @VladimirZaets, thank you for the review.
ENGCOM-7629 has been created to process this Pull Request

[engcom-Charlie]

@magento run all tests

[aleron75]

The failing functional test doesn't seem related to this PR; furthermore, I don't understand the code mess checker that complains about too many dependencies which I don't see in the constructor. Thus I approve.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-7629 has been created to process this Pull Request

[engcom-Charlie]

@magento run all tests

[engcom-Charlie]

The failing functional test doesn't seem related to this PR; furthermore, I don't understand the code mess checker that complains about too many dependencies which I don't see in the constructor. Thus I approve.

Code mess checker was fallen due to the number of classes in use. So I suppress this warning.
Please approve it.

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-7629 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed
❌ Before:

✔️ After:

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.