Skip to content

Cleanup duplicate html class #28639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2020
Merged

Cleanup duplicate html class #28639

merged 2 commits into from
Jul 29, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

Description (*)

Reopen pull request as request from core maintainer
This PR clean the duplicate class in template shipment

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Incorrect CSS selector in shipment page #28345

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Cleanup duplicate html class #29261: Cleanup duplicate html class

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn mrtuvn mentioned this pull request Jun 9, 2020
Closed
5 tasks
@ihor-sviziev ihor-sviziev self-assigned this Jun 10, 2020
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jun 10, 2020
lbajsarowicz
lbajsarowicz approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍 Could you make sure that all the related selectors in functional tests are adjusted, too?

@ghost ghost assigned lbajsarowicz Jun 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7658 has been created to process this Pull Request

lbajsarowicz
lbajsarowicz suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍 Could you make sure that all the related selectors in functional tests are adjusted, too?

@ihor-sviziev ihor-sviziev removed their assignment Jun 10, 2020
@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from a310ff8 to c28d215 Compare June 10, 2020 07:24
@mrtuvn mrtuvn requested a review from lbajsarowicz June 10, 2020 07:24
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from c28d215 to 8f96ab5 Compare June 12, 2020 23:18
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from 8f96ab5 to c81135f Compare June 17, 2020 23:40
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 17, 2020

@magento run all tests

@lbajsarowicz
Copy link
Contributor

@magento run Static Tests

@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from ca7bead to d2e72c2 Compare June 18, 2020 23:38
@ihor-sviziev ihor-sviziev removed their assignment Jun 19, 2020
@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from d2e72c2 to 13fe5c6 Compare June 19, 2020 09:05
@ihor-sviziev
Copy link
Contributor

@magento run all tests

fix static tests fails
add79e6 
update


update


fix static test
@mrtuvn mrtuvn force-pushed the cleanup-duplicate-class branch from 13fe5c6 to add79e6 Compare June 20, 2020 08:06
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 20, 2020 •
edited
Loading

got struggle with fix static the line 22. Very fun
attempt #1 Multi-line function call not indented correctly; expected 16 spaces but found 24
attempt #2 Change indent back to 16 Line indented incorrectly; expected at least 24 spaces, found 16
i have to create new line after tag open

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 28, 2020

@magento run all tests

@engcom-Delta engcom-Delta self-assigned this Jul 9, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked that print shipment works as before
Before:
MainOrder # 000000002.pdf
image

After:
PROrder # 000000003.pdf
image

@engcom-Charlie engcom-Charlie self-assigned this Jul 9, 2020
@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 21, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 24, 2020
Closed
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 24, 2020
@ghost ghost added Progress: accept Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. and removed Progress: extended testing labels Jul 27, 2020
@slavvka slavvka mentioned this pull request Jul 29, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2020
@slavvka
ENGCOM-7658: Cleanup duplicate html class #28639
0f6dd1d
@magento-engcom-team magento-engcom-team merged commit 320d74c into magento:2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the cleanup-duplicate-class branch August 15, 2020 02:59
@engcom-Alfa engcom-Alfa mentioned this pull request Nov 10, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: Sales Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Cleanup duplicate html class Incorrect CSS selector in shipment page
6 participants
@mrtuvn @ihor-sviziev @magento-engcom-team @lbajsarowicz @engcom-Delta @engcom-Charlie