Skip to content

MFTF: Sharing Wishlist with more than allowed emails qty test #28641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2020
Merged

MFTF: Sharing Wishlist with more than allowed emails qty test #28641

merged 3 commits into from
Jun 19, 2020

Conversation

DmitryTsymbal
Copy link
Contributor

@DmitryTsymbal DmitryTsymbal commented Jun 9, 2020 •
edited by m2-assistant bot
Loading

This PR contains a test for sharing customer's wishlist with more than allowed emails qty

Steps to reproduce:

1 - Set maximum allowed qty of emails for sharing
2 - Login as a customer
3 - Add product into wishlist
4 - Share wishlist with more than maximum allowed qty emails

Resolved issues:

  1. resolves [Issue] MFTF: Sharing Wishlist with more than allowed emails qty test #28720: MFTF: Sharing Wishlist with more than allowed emails qty test

@m2-assistant
Copy link

m2-assistant bot commented Jun 9, 2020

Hi @DmitryTsymbal. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Wishlist Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jun 9, 2020
@dmytro-ch dmytro-ch self-assigned this Jun 9, 2020
@dmytro-ch
Copy link
Contributor

@magento run all tests

lbajsarowicz
lbajsarowicz suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 2 minor changes.
The test name is self descriptive 👍

...o/Wishlist/Test/Mftf/Test/StorefrontShareWishlistWithMoreThanMaximumAllowedEmailsQtyTest.xml Outdated
</annotations>
<before>
<magentoCLI command="config:set wishlist/email/number_limit 1" stepKey="changeEmailsQtyLimit"/>
<magentoCLI command="cache:clean" stepKey="cleanCache"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should clean only config cache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @lbajsarowicz
CLI command edited, please check
Thanks!

...o/Wishlist/Test/Mftf/Test/StorefrontShareWishlistWithMoreThanMaximumAllowedEmailsQtyTest.xml
<createData entity="SimpleSubCategory" stepKey="createCategory"/>
<createData entity="SimpleProduct" stepKey="createProduct">
<requiredEntity createDataKey="createCategory"/>
</createData>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating product and category, you should run <magentoCron for index group.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Cron Magento CLI command on 27 line
Please check.
Thanks!

@ghost ghost assigned lbajsarowicz Jun 10, 2020
@lbajsarowicz
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests CE, Functional Tests EE

lbajsarowicz
lbajsarowicz approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Well done!

Let's wait for Functional tests to execute, but everything should be fine now.

@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7660 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 15, 2020
@engcom-Alfa engcom-Alfa self-assigned this Jun 15, 2020
@engcom-Alfa engcom-Alfa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jun 15, 2020
@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jun 15, 2020
Closed
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Charlie engcom-Charlie self-assigned this Jun 15, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 15, 2020
@engcom-Alfa engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 15, 2020
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2020
@slavvka
ENGCOM-7660: MFTF: Sharing Wishlist with more than allowed emails qty…
7d3594e 
… test #28641
@magento-engcom-team magento-engcom-team merged commit 2cfa3ec into magento:2.4-develop Jun 19, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @DmitryTsymbal, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@dmytro-ch dmytro-ch

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: MFTF test coverage Component: Wishlist Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] MFTF: Sharing Wishlist with more than allowed emails qty test
6 participants
@DmitryTsymbal @dmytro-ch @lbajsarowicz @magento-engcom-team @engcom-Alfa @engcom-Charlie