Skip to content

magento/28577_undeclared_webapi_dependency-fix #28666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 19, 2020
Merged

magento/28577_undeclared_webapi_dependency-fix #28666

merged 4 commits into from
Jun 19, 2020

Conversation

sasha19957099
Copy link
Contributor

@sasha19957099 sasha19957099 commented Jun 10, 2020 •
edited
Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 10, 2020

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099 sasha19957099 linked an issue Jun 10, 2020 that may be closed by this pull request
GraphQL module has undeclared dependency on Webapi module #28577
Closed
@nrkapoor nrkapoor added this to the 2.4.1 milestone Jun 11, 2020
@danielrenaud danielrenaud requested review from danielrenaud and removed request for avattam06 and prabhuram93 June 12, 2020 16:11
danielrenaud
danielrenaud suggested changes Jun 12, 2020
View reviewed changes
composer.lock Outdated
@@ -210,24 +210,24 @@
},
{
"name": "composer/composer",
"version": "1.10.6",
"version": "1.10.7",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to update dependencies as a part of this change.
You can use composer update -lock to only update composer.lock hash without updating dependencies

@ghost ghost assigned danielrenaud Jun 12, 2020
@sasha19957099 sasha19957099 force-pushed the 28577_GraphQL_module_has_undeclared_dependency_on_Webapi_module branch from 7c8c30c to e1accde Compare June 16, 2020 19:58
@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@sasha19957099
Copy link
Contributor Author

@magento run all tests

@danielrenaud
Copy link
Contributor

Manual testing not needed since this doesn't touch functionality. Automated tests will be enough

@danielrenaud danielrenaud added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 17, 2020
@danielrenaud danielrenaud self-requested a review June 17, 2020 21:32
magento-engcom-team pushed a commit that referenced this pull request Jun 19, 2020
@cpartica
ENGCOM-7702: magento/28577_undeclared_webapi_dependency-fix #28666
e45103b
@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @sasha19957099, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team merged commit c0694ed into magento:2.4-develop Jun 19, 2020
@sasha19957099 sasha19957099 deleted the 28577_GraphQL_module_has_undeclared_dependency_on_Webapi_module branch June 19, 2020 05:21
@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
ihor-sviziev
ihor-sviziev reviewed Oct 7, 2020
View reviewed changes
...te/Magento/Test/Integrity/_files/dependency_test/whitelist/redundant_dependencies_webapi.php
Comment on lines +6 to +12
declare(strict_types=1);

return [
'Magento\GraphQl' => [
'Magento\Webapi' => 'Magento\Webapi'
]
];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sasha19957099 @danielrenaud,
Could you explain why this file was added? Seems like test shouldn't fail anymore as it has declared dependency on web api module. An I wrong?

@ghost ghost assigned ihor-sviziev Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev left review comments

@danielrenaud danielrenaud danielrenaud approved these changes

@prabhuram93 prabhuram93 Awaiting requested review from prabhuram93

@avattam06 avattam06 Awaiting requested review from avattam06

@dthampy dthampy Awaiting requested review from dthampy

Assignees

@ihor-sviziev ihor-sviziev

@sasha19957099 sasha19957099

@danielrenaud danielrenaud

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: GraphQL GraphQL PAP Partners acceleration program Progress: accept Project: GraphQL Release Line: 2.4
Projects
None yet
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

GraphQL module has undeclared dependency on Webapi module
6 participants
@sasha19957099 @danielrenaud @ihor-sviziev @nrkapoor @cpartica @magento-engcom-team