Skip to content

magento/magento2#28564: Handle empty masked quote id return case #28714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

pmarjan
Copy link
Contributor

@pmarjan pmarjan commented Jun 13, 2020

Update resolver: delegate resolving to Quote CustomerCartResolver

Update resolver: delegate resolving to Quote CustomerCartResolver
@m2-assistant
Copy link

m2-assistant bot commented Jun 13, 2020

Hi @pmarjan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@pmarjan
Copy link
Contributor Author

pmarjan commented Jun 13, 2020

@magento run all tests

@pmarjan pmarjan linked an issue Jun 13, 2020 that may be closed by this pull request
@rogyar rogyar self-assigned this Jun 14, 2020
@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 14, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@rogyar
Copy link
Contributor

rogyar commented Jun 14, 2020

For QA. Additional autotests are not required here since the changed logic is already covered by API-functional tests. It's just a refactoring of the existing resolver.

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7681 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Jun 19, 2020

Hi @pmarjan, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@cpartica cpartica added the PAP Partners acceleration program label Jun 25, 2020
@pmarjan pmarjan deleted the graphql-28564 branch July 2, 2020 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: QuoteGraphQl PAP Partners acceleration program Partner: Comwrap partners-contribution Pull Request is created by Magento Partner Progress: accept Project: GraphQL Release Line: 2.4
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Handle empty masked quote id return case
6 participants