-
Notifications
You must be signed in to change notification settings - Fork 9.4k
magento/magento2#28564: Handle empty masked quote id return case #28714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
magento/magento2#28564: Handle empty masked quote id return case #28714
Conversation
Update resolver: delegate resolving to Quote CustomerCartResolver
Hi @pmarjan. Thank you for your contribution
❗ Automated tests can be triggered manually with an appropriate comment:
You can find more information about the builds here ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review. For more details, please, review the Magento Contributor Guide documentation. |
@magento run all tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
For QA. Additional autotests are not required here since the changed logic is already covered by API-functional tests. It's just a refactoring of the existing resolver. |
Hi @rogyar, thank you for the review. |
Hi @pmarjan, thank you for your contribution! |
Update resolver: delegate resolving to Quote CustomerCartResolver