Fix #26504 - Broken reference errors pilling up logs

[Bartlomiejsz]

Description (*)

All of other Broken reference logs across Magento are only logged in developer mode. This PR fixes the only place from which it was logged also in production mode, possibly causing pilling up of logs

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Broken reference errors piling up logs #26504

Manual testing scenarios (*)

Please check fixed issue for steps to reproduce

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Bartlomiejsz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[Bartlomiejsz]

@magento run all tests

[ihor-sviziev]

Hi @Bartlomiejsz,
Could you cover your changes with some type of test?

[Bartlomiejsz]

Hi @ihor-sviziev, to be honest I'm not sure here. Whole GeneratorPool class is pretty complex, and currently have no unit tests (MFTF are not applicable I believe).
So to cover this one minor change (which is already part of few other classes in core) I would have to write test for process method which, as mentioned is very complex at this point and this has nothing to do with my change.

[ihor-sviziev]

@Bartlomiejsz yeah, make sense. So I changed label to "not required".
Thank you!

[ihor-sviziev]

✔ Approved.

Failing functional tests looks not related to changes form this PR.

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7692 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Preconditions:

1. Custom theme extended from Luma;
2. Enabled Production mode;

Manual testing scenario:

1. Extend luma theme;
2. Move the container:
   app/design/frontend/Theme/theme/Magento_Theme/layout/default.xml:

<move element="content.top" destination="category.view.container" />

3. Go to Storefront and browse different pages;
4. Check system.log file

Before: ✖️ Logs are full of Broken reference errors

After: ✔️ Broken reference errors are only logged in developer mode

[m2-assistant]

Hi @Bartlomiejsz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.