Skip to content

"Create Permanent Redirect for URLs if URL Key Changed" for categories #28752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 16, 2020
Merged

"Create Permanent Redirect for URLs if URL Key Changed" for categories #28752

merged 8 commits into from
Jul 16, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed and covered by the test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes "Create Permanent Redirect for URLs if URL Key Changed" for categories #24922

Manual testing scenarios (*)

see #24922

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@magento magento deleted a comment from m2-assistant bot Jun 17, 2020
@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Jun 17, 2020
@swnsma swnsma self-requested a review June 21, 2020 10:14
@swnsma swnsma self-assigned this Jun 21, 2020
swnsma
swnsma requested changes Jun 21, 2020
View reviewed changes
Copy link
Contributor

@swnsma swnsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @engcom-Charlie,

Could you please check next case:

  1. When Go to Stores > Configuration > Catalog > Catalog > Search Engine Optimisation and set Create Permanent Redirect for URLs if URL Key Changed is set to "YES" (by default), checkbox is disabled until you start to edit url-key (which is fine).

Screen Shot 2020-06-21 at 1 26 08 PM

  1. When Go to Stores > Configuration > Catalog > Catalog > Search Engine Optimisation and set Create Permanent Redirect for URLs if URL Key Changed is set to "NO", checkbox is not disabled even if you have not changed anything.

Screen Shot 2020-06-21 at 1 25 17 PM

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie requested a review from swnsma June 22, 2020 07:39
@swnsma swnsma added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage labels Jun 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-7724 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jun 30, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked scenario from #24922

❌ Before:
#28752Main

✔️ After:
#28752PR

@engcom-Echo engcom-Echo self-assigned this Jun 30, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 30, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jul 1, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo requested a review from swnsma July 2, 2020 10:07
@magento-engcom-team
Copy link
Contributor

Hi @swnsma, thank you for the review.
ENGCOM-7724 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

Notice: QA not applicable.
Only MFTF was added in last commit

@engcom-Echo
Copy link
Contributor

@magento run all tests

@slavvka slavvka added this to the 2.4.1 milestone Jul 6, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 16, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Jul 16, 2020
@slavvka
ENGCOM-7724: "Create Permanent Redirect for URLs if URL Key Changed" …
1c14b83 
…for categories #28752
@magento-engcom-team magento-engcom-team merged commit 15528be into magento:2.4-develop Jul 16, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 16, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swnsma swnsma swnsma approved these changes

Assignees

@swnsma swnsma

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Award: test coverage Component: Catalog Component: CatalogUrlRewrite Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

"Create Permanent Redirect for URLs if URL Key Changed" for categories
6 participants
@engcom-Charlie @magento-engcom-team @engcom-Delta @engcom-Echo @swnsma @slavvka