Skip to content

Unable to create customer token via REST #28822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2020

Conversation

engcom-Charlie
Copy link
Contributor

Description (*)

Fixed and covered by test.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Magento CE 2.3.X the swagger interface api named integrationCustomerTokenServiceV1 http scheme valid customer acess details entered and execute still server response is 401 #27098

Manual testing scenarios (*)

See #27098

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@engcom-Charlie
Copy link
Contributor Author

@magento run all tests

@engcom-Charlie engcom-Charlie changed the title Unable to create customer token Unable to create customer token via REST Jun 22, 2020
@ihor-sviziev ihor-sviziev self-assigned this Jun 22, 2020
@ghost ghost added the Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. label Jun 22, 2020
@ihor-sviziev ihor-sviziev added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7720 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed
Manual testing scenario:

  • Create customer
  • Open the default magento Swagger
  • Open integrationCustomerTokenServiceV1 interface to generate token for customer
  • Enter the integrationCustomerTokenServiceV1CreateCustomerAccessTokenPostBody as registered customer acess details to generate token for customer.

Before:
#28822Main

✔️ After:
#28822PR

@engcom-Echo engcom-Echo self-assigned this Jun 24, 2020
@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jun 25, 2020
@ghost ghost added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Jun 25, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jun 25, 2020
@engcom-Delta engcom-Delta added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Jun 26, 2020
@magento-engcom-team magento-engcom-team merged commit 7e80b18 into magento:2.4-develop Jun 27, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jun 27, 2020

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Customer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
Archived in project
6 participants