Skip to content

#28829 Fixing multiple typos #28832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2020
Merged

#28829 Fixing multiple typos #28832

merged 1 commit into from
Jul 11, 2020

Conversation

pgrimaud
Copy link
Member

Description (*)

Fixing multiple typos

Related Pull Requests

N/A

Fixed Issues (if relevant)

  1. Fixes Typos on code #28829 (Typos on code)
  2. Fixes other typos

Manual testing scenarios (*)

N/A

Questions or comments

Checked for other occurrences. LGTM.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 22, 2020

Hi @pgrimaud. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@pgrimaud
Copy link
Member Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Jun 22, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. labels Jun 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7745 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

@pgrimaud thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@engcom-Delta
Copy link
Contributor

✔️ QA passed
Was checked that select on customers grid and customer edit page(Addresses tab) is same as before typo fix
Before:
#28832Main

After:
#28832PRCustomerGrid

@engcom-Charlie engcom-Charlie self-assigned this Jul 8, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 9, 2020
@slavvka slavvka added the Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. label Jul 9, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Jul 11, 2020
5 tasks
@magento-engcom-team magento-engcom-team merged commit 2cc3c73 into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @pgrimaud, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Component: App Component: Authorization Component: Bundle Component: Cms Component: ConfigurableProduct Component: Cookie Component: Customer Component: Locale Component: Paypal Component: Test Priority: P4 No current plan to fix. Fixing can be deferred as a logical part of more important work. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Typos on code
6 participants