Initialize toolbar.js once

[ptylek]

Description (*)

Continue work that was done by @Nagamaiah007 in #26097.
I changed approach to set events with proper scope of toolbar that javascript is initialized with in order not to process events twice. Previously _bind function was adding events for data-role selectors that were not assigned to this.element scope, so if we had two toolbars on the page (toolbar top and bottom), all events were incorrectly assigned with first toolbar initialization. This change fixes scope for these data-role selectors and won't trigger specific functions to be run twice.

Related Pull Requests

#26097: Update toolbar.js #25934

Fixed Issues (if relevant)

1. Fixes chrome initiate two times toolbar.js #25934

Manual testing scenarios (*)

1. Got to product list, search or advance search page
2. Open developer tools -> Network tab (Chrome browser)
3. Select/click any of the toolbar option like Grid/List, Sort By, or show X per page
4. Network(Chrome Browser) selected/clicked link triggering two time and because of two time trigger backed doing twice process after canceled one also. (for verify put any log in to catalog->product->list controller).

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[ptylek]

@magento run all tests

[ptylek]

@magento run all tests

[ptylek]

@magento run all tests

[ptylek]

@magento run all tests

[magento-engcom-team]

Hi @krzksz, thank you for the review.
ENGCOM-7834 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Got to the product list, search or advance search page;
2. Open developer tools -> Network tab (Chrome browser);
3. Select/click any of the toolbar options like Grid/List, Sort By, or show X per page;
4. Network(Chrome Browser) selected/clicked link triggering two time and because of two time trigger backed doing twice process after canceled one also. (for verify put any log in to catalog->product->list controller).

Before: ✖️ On click/change link trigger two times

After: ✔️ Link triggered once

Toolbar functionality is still working as previously (expected).

[m2-assistant]

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.