Skip to content

Cover form email component in checkout page with jasmine test #28842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2020
Merged

Cover form email component in checkout page with jasmine test #28842

merged 1 commit into from
Aug 1, 2020

Conversation

mrtuvn
Copy link
Contributor

@mrtuvn mrtuvn commented Jun 23, 2020 •
edited
Loading

Reopen closed my PR. This PR aims to apply cover test jasmine for js component
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Checkout/view/frontend/web/js/view/form/element/email.js

Description (*)

Related Pull Requests

#27691

Fixed Issues (if relevant)

  1. Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 23, 2020

Hi @mrtuvn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jun 28, 2020

@magento run all tests

@mrtuvn mrtuvn force-pushed the coverage-checkout-email-component-by-jasmine branch from d13f467 to 3196e7d Compare July 14, 2020 14:28
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 17, 2020

@magento run all tests

@ghost ghost assigned ihor-sviziev Jul 26, 2020
@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage labels Jul 26, 2020
@mrtuvn mrtuvn force-pushed the coverage-checkout-email-component-by-jasmine branch from 3196e7d to 3197af5 Compare July 26, 2020 12:55
@mrtuvn mrtuvn requested a review from ihor-sviziev July 26, 2020 12:55
@mrtuvn mrtuvn force-pushed the coverage-checkout-email-component-by-jasmine branch from 3197af5 to 4d045f5 Compare July 26, 2020 13:03
@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 26, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor Author

mrtuvn commented Jul 26, 2020

@omiroshnichenko can you review this

@ihor-sviziev
Copy link
Contributor

@magento run Integration Tests

@ihor-sviziev ihor-sviziev added the Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”. label Jul 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-7913 has been created to process this Pull Request

@engcom-Alfa engcom-Alfa self-assigned this Jul 30, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Jul 30, 2020
@slavvka slavvka added the Priority: P3 May be fixed according to the position in the backlog. label Jul 30, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 1, 2020
@slavvka
ENGCOM-7913: Cover form email component in checkout page with jasmine…
1ae8e83 
… test #28842
@magento-engcom-team magento-engcom-team merged commit fe276ac into magento:2.4-develop Aug 1, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 1, 2020

Hi @mrtuvn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@mrtuvn mrtuvn deleted the coverage-checkout-email-component-by-jasmine branch August 1, 2020 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: test coverage Component: Checkout Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S4 Affects aesthetics, professional look and feel, “quality” or “usability”.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrtuvn @ihor-sviziev @magento-engcom-team @engcom-Alfa @slavvka @engcom-Charlie