magento/magento2#27952: missing store_name in GraphQL resolver - adde… #28855

sasha19957099 · 2020-06-23T18:04:31Z

…d store_name

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

m2-assistant · 2020-06-23T18:04:33Z

Hi @sasha19957099. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

sasha19957099 · 2020-06-23T18:05:04Z

@magento run all tests

danielrenaud · 2020-06-23T20:00:57Z

app/code/Magento/StoreGraphQl/Model/Resolver/Store/StoreConfigDataProvider.php

-        $storeConfigData = array_merge(
-            $this->getBaseConfigData($store),
-            $this->getExtendedConfigData((int)$store->getId())
+        return array_merge(


I don't think we should swap these, it will change behavior in a way we may not want. If store_name is getting overwritten, you should remove this in di.xml

<arguments> <argument name="extendedConfigData" xsi:type="array"> <item name="store_name" xsi:type="string">store/information/name</item> </argument> </arguments> </type>```

danielrenaud · 2020-06-23T20:04:39Z

app/code/Magento/StoreGraphQl/Model/Resolver/Store/StoreConfigDataProvider.php

@@ -88,9 +87,9 @@ private function getBaseConfigData(StoreInterface $store) : array
            'secure_base_url' => $storeConfig->getSecureBaseUrl(),
            'secure_base_link_url' => $storeConfig->getSecureBaseLinkUrl(),
            'secure_base_static_url' => $storeConfig->getSecureBaseStaticUrl(),
-            'secure_base_media_url' => $storeConfig->getSecureBaseMediaUrl()
+            'secure_base_media_url' => $storeConfig->getSecureBaseMediaUrl(),
+            'store_name' => $storeConfig->getStoreName()


While you're changes look correct, I just wonder if we could do it in a less disruptive way. The current approach introduces a backwards incompatible change because we're adding a new public method to an @api interface.

Could we just use $store->getName() here and avoid the changes outside of GraphQl area?

danielrenaud · 2020-06-23T20:04:55Z

composer.lock

@@ -4,7 +4,7 @@
        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
        "This file is @generated automatically"
    ],
-    "content-hash": "e86af25d9a4a1942c437cca58f9f1efb",
+    "content-hash": "f3674961f96b48fdd025a6c94610c8eb",


We shouldn't need to update composer.lock for this

yes, but without it, local static test fails

Ok, so actually this change matches the hash in mainline, so I don't know why it is showing up as a change here. Maybe just need to sync up your branch. But it should be fine.

…ed changes

sasha19957099 · 2020-06-24T10:49:43Z

@magento run all tests

sasha19957099 · 2020-06-24T10:59:03Z

@magento run all tests

danielrenaud

looks good.
Just a minor static fix for class descriptions.

danielrenaud · 2020-06-24T15:03:29Z

app/code/Magento/Store/Api/Data/StoreConfigInterface.php

@@ -7,7 +7,7 @@

 /**
 * StoreConfig interface
- *
+ * Interface for store config


For each of these where you update the class description, can you remove the old, useless description. and add a new line
so for this one it would be

/** * Interface for store config * * @api

danielrenaud · 2020-06-24T15:06:21Z

composer.lock

@@ -4,7 +4,7 @@
        "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
        "This file is @generated automatically"
    ],
-    "content-hash": "e86af25d9a4a1942c437cca58f9f1efb",
+    "content-hash": "f3674961f96b48fdd025a6c94610c8eb",


Ok, so actually this change matches the hash in mainline, so I don't know why it is showing up as a change here. Maybe just need to sync up your branch. But it should be fine.

…esolver

…nts with class names

…nts with class name

sasha19957099 · 2020-06-25T06:12:32Z

@magento run all tests

…28855

m2-assistant · 2020-06-27T17:50:19Z

Hi @sasha19957099, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento#27952: missing store_name in GraphQL resolver - added store_name

85db11d

ghost added the Progress: pending review label Jun 23, 2020

magento-engcom-team added Component: Store Component: StoreGraphQl Release Line: 2.4 labels Jun 23, 2020

sasha19957099 added the Project: GraphQL label Jun 23, 2020

sasha19957099 linked an issue Jun 23, 2020 that may be closed by this pull request

Missing store_name in GraphQl Resolver #27952

Closed

danielrenaud self-requested a review June 23, 2020 18:46

danielrenaud suggested changes Jun 23, 2020

View reviewed changes

ghost assigned danielrenaud Jun 23, 2020

ghost added Progress: needs update and removed Progress: pending review labels Jun 23, 2020

magento#27952: missing store_name in GraphQL resolver - added request…

096aa37

…ed changes

Update StoreConfigDataProvider.php

de9ff7d

sasha19957099 requested a review from danielrenaud June 24, 2020 13:19

danielrenaud suggested changes Jun 24, 2020

View reviewed changes

sasha19957099 added 3 commits June 24, 2020 18:18

Merge branch '2.4-develop' into 27952_Missing_store_name_in_GraphQl_R…

1e6c55a

…esolver

magento#27952: missing store_name in GraphQL resolver - small amendme…

42c534c

…nts with class names

magento#27952: missing store_name in GraphQL resolver - small amendme…

c3e38ac

…nts with class name

sasha19957099 requested a review from danielrenaud June 24, 2020 20:26

danielrenaud approved these changes Jun 24, 2020

View reviewed changes

ghost added Progress: ready for testing Progress: testing in progress and removed Progress: needs update Progress: ready for testing Progress: testing in progress labels Jun 24, 2020

ghost added the Progress: accept label Jun 24, 2020

cpartica added the PAP Partners acceleration program label Jun 24, 2020

magento-engcom-team pushed a commit that referenced this pull request Jun 27, 2020

ENGCOM-7740: #27952: missing store_name in GraphQL resolver - adde… #…

576b05a

…28855

magento-engcom-team merged commit 0fa74d5 into magento:2.4-develop Jun 27, 2020

sasha19957099 deleted the 27952_Missing_store_name_in_GraphQl_Resolver branch September 18, 2020 13:41

gabrieldagama mentioned this pull request Mar 23, 2021

issue with store name into graph ql has been resolved #27984

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

magento/magento2#27952: missing store_name in GraphQL resolver - adde… #28855

magento/magento2#27952: missing store_name in GraphQL resolver - adde… #28855

Uh oh!

sasha19957099 commented Jun 23, 2020

Uh oh!

m2-assistant bot commented Jun 23, 2020

Uh oh!

sasha19957099 commented Jun 23, 2020

Uh oh!

danielrenaud Jun 23, 2020

Uh oh!

danielrenaud Jun 23, 2020 •

edited

Loading

Uh oh!

danielrenaud Jun 23, 2020

Uh oh!

sasha19957099 Jun 24, 2020 •

edited

Loading

Uh oh!

danielrenaud Jun 24, 2020

Uh oh!

sasha19957099 commented Jun 24, 2020

Uh oh!

sasha19957099 commented Jun 24, 2020

Uh oh!

danielrenaud left a comment

Uh oh!

danielrenaud Jun 24, 2020

Uh oh!

danielrenaud Jun 24, 2020

Uh oh!

sasha19957099 commented Jun 25, 2020

Uh oh!

m2-assistant bot commented Jun 27, 2020

Uh oh!

Uh oh!

magento/magento2#27952: missing store_name in GraphQL resolver - adde… #28855

magento/magento2#27952: missing store_name in GraphQL resolver - adde… #28855

Uh oh!

Conversation

sasha19957099 commented Jun 23, 2020

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Uh oh!

m2-assistant bot commented Jun 23, 2020

Uh oh!

sasha19957099 commented Jun 23, 2020

Uh oh!

danielrenaud Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

danielrenaud Jun 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielrenaud Jun 23, 2020

Choose a reason for hiding this comment

Uh oh!

sasha19957099 Jun 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

danielrenaud Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

sasha19957099 commented Jun 24, 2020

Uh oh!

sasha19957099 commented Jun 24, 2020

Uh oh!

danielrenaud left a comment

Choose a reason for hiding this comment

Uh oh!

danielrenaud Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

danielrenaud Jun 24, 2020

Choose a reason for hiding this comment

Uh oh!

sasha19957099 commented Jun 25, 2020

Uh oh!

m2-assistant bot commented Jun 27, 2020

Uh oh!

Uh oh!

danielrenaud Jun 23, 2020 •

edited

Loading

sasha19957099 Jun 24, 2020 •

edited

Loading