Create or update customer don't validate customer group id

[engcom-Charlie]

Description (*)

Added customer group id validation to create/update, covered by tests

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Web Api to create customer don't validate payload data and create corrupted record #28064

Manual testing scenarios (*)

See #28064

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Charlie. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[engcom-Charlie]

@magento run all tests

[eduard13]

Hi @engcom-Charlie, thank you for the fix.
Could you please check my comment and also slightly adjust the save method to fix the failing static tests?
Thank you.

[engcom-Charlie]

@magento run all tests

[eduard13]

Could you please check the below comment?

[engcom-Charlie]

@magento run all tests

[eduard13]

Thank you @engcom-Charlie for adjusting it 👍.
Don't think that the failed test is somehow related with these changes.

[magento-engcom-team]

Hi @eduard13, thank you for the review.
ENGCOM-7785 has been created to process this Pull Request

[engcom-Alfa]

✔️ QA Passed

Case 1. POST request

Manual testing scenario:

1. Send a POST request to the endpoint /rest/V1/customers;

2. In the payload send an invalid group_id ( 8 for example);

Before: ✖️ The customer was successfully created with invalid group_id

✖️ The customer can't see products or add products to the quote

After: ✔️ throws an Exception informing that the group_id is not found

Case 2. PUT request

1. Send a PUT request to the endpoint /rest/V1/customers/{customer id};

2. In the payload send an invalid group_id ( 8 for example);

Before: ✖️ The customer was successfully updated with invalid group_id

After: ✔️ throws an Exception informing that the group_id is not found

[engcom-Echo]

@magento run Functional Tests B2B

[slavvka]

@magento Functional Tests CE

[slavvka]

@magento Functional Tests CE

[slavvka]

@magento run Functional Tests CE

[m2-assistant]

Hi @engcom-Charlie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.