Support cron expressions like 3/10 * * * * and handle hyphen expres…

[AntonEvers]

Description (*)

Cron expressions like 3/10 * * * * are now not scheduled. They should be scheduled at every 10 minutes, starting at 3 minutes past the hour.

Fixed Issues (if relevant)

1. PR Support cron expressions like 3/10 * * * * and handle hyphen expres… #28930

Manual testing scenarios (*)

1. Plan a cron job with the expression 3/10 * * * *
2. Run bin/magento cron:run
3. See how it does not get scheduled

after applying the PR, it will get scheduled.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

Resolved issues:

1. resolves [Issue] Support cron expressions like 3/10 * * * * and handle hyphen expres… #29240: Support cron expressions like 3/10 * * * * and handle hyphen expres…

[m2-assistant]

Hi @AntonEvers. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[AntonEvers]

@magento run Unit Tests

[rogyar]

@magento run all tests

[AntonEvers]

@rogyar I think we're good, right? The first 2 static tests seem to fail on every PR so I don't think they have anything to do with this addition.

[rogyar]

@magento run Functional Tests B2B

[rogyar]

It does look like a set of flaky tests, but let's double-check this fact

[AntonEvers]

It does look like a set of flaky tests, but let's double-check this fact

I cannot imagine that this PR will have an effect on frontend HTML elements. So indeed, they look like flaky tests that come up due to me merging 2.4-develop

[AntonEvers]

@magento run all tests

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-7863 has been created to process this Pull Request

[engcom-Alfa]

@magento create issue

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Plan a cron job with the expression 3/10 * * * *
2. Run bin/magento cron:run.

Before: ✖️ cron task with expression 3/10 * * * * was not scheduled

After: ✔️ cron task with expression 3/10 * * * * was successfully scheduled .
They scheduled every 10 minutes, starting at 3 minutes past the hour.

[engcom-Kilo]

@magento run all tests

[engcom-Kilo]

Failed Functional Tests B2B not related to the changes in this PR.

[m2-assistant]

Hi @AntonEvers, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.