Skip to content

[MFTF] use action group go to attribute grid page #28956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2020
Merged

[MFTF] use action group go to attribute grid page #28956

merged 2 commits into from
Jul 11, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 1, 2020

This PR use AdminOpenProductAttributePageActionGroup to go to ProductAttributeGridPage

@m2-assistant
Copy link

m2-assistant bot commented Jul 1, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 1, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 1, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

lbajsarowicz
lbajsarowicz approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@lbajsarowicz lbajsarowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great catch. Thank you.
If you don't mind, change the words order to have subject (product attribute page) first and then action (page open)

@ghost ghost assigned lbajsarowicz Jul 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lbajsarowicz, thank you for the review.
ENGCOM-7774 has been created to process this Pull Request
✳️ @lbajsarowicz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

Hi @lbajsarowicz
Yes I can do it . But I think it's a backward-incompatible change since 3rd party modules may rely on this core action group.
What do you think ?
Thanks.

@lbajsarowicz
Copy link
Contributor

Yes, you are right 👍 I haven't noticed that was already there.

@engcom-Delta engcom-Delta self-assigned this Jul 8, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Charlie engcom-Charlie self-assigned this Jul 8, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@engcom-Charlie engcom-Charlie added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jul 9, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 9, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 9, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 11, 2020
@slavvka
ENGCOM-7774: [MFTF] use action group go to attribute grid page #28956
d89dbdd
@magento-engcom-team magento-engcom-team merged commit 92b2de3 into magento:2.4-develop Jul 11, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 11, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbajsarowicz lbajsarowicz lbajsarowicz approved these changes

Assignees

@lbajsarowicz lbajsarowicz

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Component: ConfigurableProduct Component: Elasticsearch Component: Swatches Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.
6 participants
@Usik2203 @magento-engcom-team @lbajsarowicz @engcom-Delta @engcom-Charlie @slavvka