magento/magento2#28957: GraphQl. Mutation: customerOrders query and gift_message attribute

[atwixfirster]

Description (*)

PR fixes #28957

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes magento/magento228957: GraphQl. Mutation: customerOrders query and gift_message attribute

Manual testing scenarios (*)

1. Magento (2.4-develop) with a sample data
2. Generate customer token:

mutation {
  generateCustomerToken(
    email: "[email protected]"
    password: "[email protected]"
  ) {
    token
  }
}

1. Retrieve customer orders:

query {
    customerOrders {
        items {
            order_number
            gift_message {
                to
                from
                message
            }
        }
    }
}

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

[atwixfirster]

@magento run all tests

[atwixfirster]

@magento run Database Compare

[atwixfirster]

@magento run WebAPI Tests

[atwixfirster]

@magento run Unit Tests

[atwixfirster]

@magento Static Tests

[atwixfirster]

@magento run Semantic Version Checker

[atwixfirster]

@magento run Functional Tests B2B

[atwixfirster]

@magento run Sample Data Tests EE Sample Data Tests CE Sample Data Tests B2B Magento Health Index

[dmytro-ch]

Hello @atwixfirster, thank you for your contribution.
The overall changes look good to me.
Could you please cover this case by an appropriate functional test?

[sivaschenko]

Hi @nrkapoor , what is the reason for putting this PR on hold? Should it be processed according to priority or any additional actions are required?

[sivaschenko]

customerOrders query is deprecated:

magento2/app/code/Magento/SalesGraphQl/etc/schema.graphqls

Line 5 in 8b1d118

customerOrders: CustomerOrders @resolver(class: "Magento\\SalesGraphQl\\Model\\Resolver\\Orders") @deprecated(reason: "Use orders from customer instead") @cache(cacheable: false)

Need to check if the issue is reproducible with customer orders and update the issue and PR testing steps accordingly

[cpartica]

I think this change needs a test, plus we need to fix webAPI tests which are failing

[engcom-Alfa]

We raised internal PR- https://github.com/magento-gl/magento2ce/pull/290 along with this PR commits, covering the automation tests and resolved PR comments.
Once Internal PR will get merged will notify here