Skip to content

[MFTF] Use ActionGroup to click done on the Search Categories popup #28989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 8, 2020
Merged

[MFTF] Use ActionGroup to click done on the Search Categories popup #28989

merged 5 commits into from
Aug 8, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 3, 2020 •
edited by m2-assistant bot
Loading

This PR use AdminCategoriesClickDoneButtonOnPopupActionGroup to click done button
instead <click selector="{{AdminProductFormSection.done}}" stepKey="clickOnDoneAdvancedCategorySelect"/>

Resolved issues:

  1. resolves [Issue] [MFTF] Use ActionGroup to click done on the Search Categories popup #29380: [MFTF] Use ActionGroup to click done on the Search Categories popup

@m2-assistant
Copy link

m2-assistant bot commented Jul 3, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Component: Catalog Component: UrlRewrite Release Line: 2.4 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jul 3, 2020
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 3, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

1 similar comment
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 4, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar rogyar self-assigned this Jul 5, 2020
rogyar
rogyar requested changes Jul 5, 2020
View reviewed changes
...e/Magento/Catalog/Test/Mftf/ActionGroup/AdminCategoriesClickDoneButtonOnPopupActionGroup.xml Outdated
@@ -8,11 +8,12 @@

<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="urn:magento:mftf:Test/etc/actionGroupSchema.xsd">
<actionGroup name="AdminSubmitCategoriesPopupActionGroup">
<actionGroup name="AdminCategoriesClickDoneButtonOnPopupActionGroup">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not recommend you renaming this action group without strong necessity. It's a backward-incompatible change since 3rd party modules may rely on this core action group.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done it
Also I see that failed tests are not related with my changes.
Thanks.

@Usik2203 Usik2203 force-pushed the mftf-use-action-group-click-done-button branch from cf181d9 to 8ec67c3 Compare July 5, 2020 15:52
@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 5, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar
Copy link
Contributor

rogyar commented Jul 7, 2020

@magento run Functional Tests CE , Functional Tests B2B

1 similar comment
@rogyar
Copy link
Contributor

rogyar commented Jul 9, 2020

@magento run Functional Tests CE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@engcom-Charlie engcom-Charlie self-assigned this Jul 20, 2020
@engcom-Charlie
Copy link
Contributor

@magento run all tests

@rogyar
Copy link
Contributor

rogyar commented Jul 25, 2020

@magento run Functional Tests EE , Functional Tests B2B

@engcom-Charlie engcom-Charlie requested a review from rogyar July 27, 2020 07:25
@rogyar rogyar added the Cleanup label Jul 29, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7915 has been created to process this Pull Request
✳️ @rogyar, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa engcom-Alfa self-assigned this Aug 3, 2020
@engcom-Alfa engcom-Alfa added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Aug 3, 2020
@engcom-Alfa
Copy link
Contributor

QA not applicable

@engcom-Alfa
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Aug 4, 2020
Closed
@ghost ghost added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P3 May be fixed according to the position in the backlog. labels Aug 4, 2020
magento-engcom-team pushed a commit that referenced this pull request Aug 8, 2020
@slavvka
ENGCOM-7915: [MFTF] Use ActionGroup to click done on the Search Categ…
841cb8d 
…ories popup #28989
@magento-engcom-team magento-engcom-team merged commit 30e9ac0 into magento:2.4-develop Aug 8, 2020
@m2-assistant
Copy link

m2-assistant bot commented Aug 8, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Component: Catalog Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Use ActionGroup to click done on the Search Categories popup
5 participants
@Usik2203 @rogyar @engcom-Charlie @magento-engcom-team @engcom-Alfa