Skip to content

[MFTF] Use action group to click AdminProductGridSection.firstRow #29000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2020
Merged

[MFTF] Use action group to click AdminProductGridSection.firstRow #29000

merged 1 commit into from
Jul 29, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 6, 2020 •
edited by m2-assistant bot
Loading

This PR use AdminProductGridSectionClickFirstRowActionGroup to click AdminProductGridSection.firstRow
instead
<click selector="{{AdminProductGridSection.firstRow}}" stepKey="clickOnProductPage"/>
<waitForPageLoad stepKey="waitForProductPageLoad"/>

Resolved issues:

  1. resolves [Issue] [MFTF] Use action group to click AdminProductGridSection.firstRow #29295: [MFTF] Use action group to click AdminProductGridSection.firstRow

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests B2B

@rogyar rogyar self-assigned this Jul 6, 2020
@rogyar
Copy link
Contributor

rogyar commented Jul 7, 2020

The failing test looks like the flaky test since it's randomly being failed for other PRs as well.

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 7, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7790 has been created to process this Pull Request

@engcom-Delta engcom-Delta self-assigned this Jul 10, 2020
@engcom-Delta
Copy link
Contributor

Notice: QA not applicable

@engcom-Echo engcom-Echo self-assigned this Jul 10, 2020
@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests CE

@engcom-Echo engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 13, 2020
@slavvka slavvka added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Jul 13, 2020
@slavvka slavvka added this to the 2.4.1 milestone Jul 13, 2020
@engcom-Delta
Copy link
Contributor

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Jul 27, 2020
Closed
@engcom-Delta engcom-Delta removed the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Jul 27, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 29, 2020
@slavvka
ENGCOM-7790: [MFTF] Use action group to click AdminProductGridSection…
d1d48a0 
….firstRow #29000
@magento-engcom-team magento-engcom-team merged commit 781ba9b into magento:2.4-develop Jul 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 29, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Delta engcom-Delta

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Bundle Component: Catalog Component: ConfigurableProduct Component: Downloadable Component: Quote Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Pull Requests Dashboard
Archived in project
Milestone
2.4.1
Development

Successfully merging this pull request may close these issues.

[Issue] [MFTF] Use action group to click AdminProductGridSection.firstRow
6 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Delta @engcom-Echo @slavvka