Skip to content

[MFTF] use ActionGroup go to AdminTaxRuleGridPage #29004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 21, 2020
Merged

[MFTF] use ActionGroup go to AdminTaxRuleGridPage #29004

merged 3 commits into from
Jul 21, 2020

Conversation

Usik2203
Copy link
Contributor

@Usik2203 Usik2203 commented Jul 6, 2020 •
edited
Loading

This PR creates and uses AdminTaxRuleGridOpenPageActionGroup to go to AdminTaxRuleGridPage

@m2-assistant
Copy link

m2-assistant bot commented Jul 6, 2020

Hi @Usik2203. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

@Usik2203
Copy link
Contributor Author

Usik2203 commented Jul 6, 2020

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@rogyar rogyar self-assigned this Jul 6, 2020
@rogyar
Copy link
Contributor

rogyar commented Jul 7, 2020

@magento run Functional Tests EE

@rogyar rogyar added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jul 9, 2020
rogyar
rogyar approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failing tests are not related to the current changeset

@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-7806 has been created to process this Pull Request

@Usik2203
Copy link
Contributor Author

@magento run Functional Tests CE , Functional Tests EE , Functional Tests B2B

@engcom-Alfa engcom-Alfa self-assigned this Jul 17, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA not applicable

@engcom-Kilo engcom-Kilo self-assigned this Jul 17, 2020
@engcom-Kilo
Copy link
Contributor

@magento run all tests

@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Jul 20, 2020
@sdzhepa sdzhepa added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers labels Jul 20, 2020
magento-engcom-team pushed a commit that referenced this pull request Jul 21, 2020
@slavvka
ENGCOM-7806: [MFTF] use ActionGroup go to AdminTaxRuleGridPage #29004
75af4ac
@magento-engcom-team magento-engcom-team merged commit 05f5f37 into magento:2.4-develop Jul 21, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jul 21, 2020

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogyar rogyar rogyar approved these changes

Assignees

@rogyar rogyar

@engcom-Alfa engcom-Alfa

@engcom-Kilo engcom-Kilo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Checkout Component: Customer Component: SalesRule Component: Tax Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P3 May be fixed according to the position in the backlog. Progress: accept Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
Pull Requests Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Usik2203 @rogyar @magento-engcom-team @engcom-Alfa @engcom-Kilo @sdzhepa